[Ohrrpgce] SVN: james/12772 Fix random spell lists to check atkallowed()

[Ralph Versteegen]

This was a big bug (although I read it only affected attacks set to
"Automatically choose target"), so I think it's likely that there are games
which are significantly affected. I'd rather have a backcompat bit for it.

Actually, I wasn't suggesting that shared backcompat bit for this bugfix,
because I didn't even know about this bug when I wrote that first comment.
I still think grouping together bugfixes into one or a few backcompat bits
is good, but if you fix some now and some later it can just be split into
multiple bits... or if there's a bit of a delay before all the bugfixes are
made, it's unlikely anyone would be caught out. (If you disable backcompat
bits you probably care about bugfixes anyway!)

BTW, the git-svn cron job seems to be down again.

On Wed, 9 Feb 2022 at 16:51, James Paige <Bob at hamsterrepublic.com> wrote:

> I guess there is a small chance of this bufix breaking a game, if it
> relied on spell costs being ignored for a hero's random spell list.
> Unlikely, but possible.
>
> I'm tempted to just leave this as a simple fix, and only add a backcompat
> bit if somebody finds a game that is actually broken by this. (And I have
> zero problem with adding a line in the upgrade sub that does if gamename =
> "somegame" then flip fixbit)
>
> What are your thoughts?
>
> I see the attack costs megabug suggests a shared fix bit "Correct handling
> of attack costs" which I could create now-- though I think doing that for
> this fix means I am committing to fix all four of the bugs mentioned under
> that fixbit also before the next stable release (which is not a bad thing I
> guess?)
>
> On Tue, Feb 8, 2022 at 4:03 PM James Paige <Bob at hamsterrepublic.com>
> wrote:
>
>> Oh, I missed that this one had already been split out into a separate bug
>> https://github.com/ohrrpgce/ohrrpgce/issues/394
>>
>> On Tue, Feb 8, 2022 at 4:01 PM <subversion at hamsterrepublic.com> wrote:
>>
>>> james
>>> 2022-02-08 13:01:45 -0800 (Tue, 08 Feb 2022)
>>> 103
>>> Fix random spell lists to check atkallowed()
>>>
>>> resolves one tiny little part of the attack costs megabug
>>> ---
>>> U   wip/bmod.rbas
>>> U   wip/bmodsubs.bas
>>> U   wip/bmodsubs.bi
>>>
>>> _______________________________________________
>>> Ohrrpgce mailing list
>>> ohrrpgce at lists.motherhamster.org
>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>
>> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20220209/f04fcbd5/attachment.html>