[Ohrrpgce] SVN: james/12772 Fix random spell lists to check atkallowed()

[James Paige]

I guess there is a small chance of this bufix breaking a game, if it relied
on spell costs being ignored for a hero's random spell list. Unlikely, but
possible.

I'm tempted to just leave this as a simple fix, and only add a backcompat
bit if somebody finds a game that is actually broken by this. (And I have
zero problem with adding a line in the upgrade sub that does if gamename =
"somegame" then flip fixbit)

What are your thoughts?

I see the attack costs megabug suggests a shared fix bit "Correct handling
of attack costs" which I could create now-- though I think doing that for
this fix means I am committing to fix all four of the bugs mentioned under
that fixbit also before the next stable release (which is not a bad thing I
guess?)

On Tue, Feb 8, 2022 at 4:03 PM James Paige <Bob at hamsterrepublic.com> wrote:

> Oh, I missed that this one had already been split out into a separate bug
> https://github.com/ohrrpgce/ohrrpgce/issues/394
>
> On Tue, Feb 8, 2022 at 4:01 PM <subversion at hamsterrepublic.com> wrote:
>
>> james
>> 2022-02-08 13:01:45 -0800 (Tue, 08 Feb 2022)
>> 103
>> Fix random spell lists to check atkallowed()
>>
>> resolves one tiny little part of the attack costs megabug
>> ---
>> U   wip/bmod.rbas
>> U   wip/bmodsubs.bas
>> U   wip/bmodsubs.bi
>>
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20220208/f31e1d5c/attachment.html>