[Ohrrpgce] [ohrrpgce/ohrrpgce] Add support for Steam achievements (PR #1229)

[Ralph Versteegen]

I tried initialising Steamworks after creating the window and it works normally, but the program crashes when you quit, inside the OpenGL driver. So I don't think we'll be doing that.

So, uh, sorry I wasn't clear, but I wasn't suggesting switching to two-space indents (not a fan personally). Because I believed you had your editor set to 4-space tabs I suggested switching to tabs as a minimal change which improves consistency. But really, you can use 4 spaces if you want, since each module uses its own code style (which is baffling). Likewise, indent inside the namespace if you have a strong preference.

I'm happy to have steam notifications for non-permanent achievements. But if the player previously received it in another game steam presumably won't display anything? If you select non-permanent achievements I think you expect the engine to always show a notification. Does that mean we should also show a slice-based notification in addition to the steam one? Or should we just remove the achievement and then immediately re-award it to force a notification?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/pull/1229#issuecomment-974983094
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20211121/8d66775a/attachment.html>