<p></p>
<p dir="auto">I tried initialising Steamworks after creating the window and it works normally, but the program crashes when you quit, inside the OpenGL driver. So I don't think we'll be doing that.</p>
<p dir="auto">So, uh, sorry I wasn't clear, but I wasn't suggesting switching to two-space indents (not a fan personally). Because I believed you had your editor set to 4-space tabs I suggested switching to tabs as a minimal change which improves consistency. But really, you can use 4 spaces if you want, since each module uses its own code style (which is baffling). Likewise, indent inside the namespace if you have a strong preference.</p>
<p dir="auto">I'm happy to have steam notifications for non-permanent achievements. But if the player previously received it in another game steam presumably won't display anything? If you select non-permanent achievements I think you expect the engine to always show a notification. Does that mean we should also show a slice-based notification in addition to the steam one? Or should we just remove the achievement and then immediately re-award it to force a notification?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ohrrpgce/ohrrpgce/pull/1229#issuecomment-974983094">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AMWGWZUUZNV7B2TFXFOULQ3UNGJ45ANCNFSM5IIWNISA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AMWGWZQU7G6BDV5P23Y2F33UNGJ45A5CNFSM5IIWNISKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHIOQ7NQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ohrrpgce/ohrrpgce/pull/1229#issuecomment-974983094",
"url": "https://github.com/ohrrpgce/ohrrpgce/pull/1229#issuecomment-974983094",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>