[Ohrrpgce] [ohrrpgce/ohrrpgce] Sell menu crashes or broken when max inventory size is greater than screen size (#11)

[Ralph Versteegen]

Definitely a release-blocker... not just because it turns out that it causes crashes in a number of games.

Have three crash reports for this (4445d2bf, d48c50da, 2e5ba8cd), all with identical backtrace:

```
----- Stacktrace -----
@ [game.exe + 0x1e497c]
@ [game.exe + 0x1e3605]
@ SELLSTUFF            	(menustuf.rbas:1770 + 0x28)
   1768   ELSE
   1769    item_name = inventory(i).text
 ->1770   END IF
   1771   printstr item_name, 20 + 96 * (i MOD 3), 12 + 8 * ((i - top) \ 3), page
@ SHOP                 	(moresubs.rbas:1650 + 0x15)
   1648   IF menuid(st.pt) = 1 THEN '--SELL
   1649    sellstuff id, storebuf()
 ->1650   END IF
   1651   IF menuid(st.pt) = 2 THEN '--HIRE
@ ADVANCE_TEXT_BOX     	(game.bas:3482 + 0x9)
   3480   IF txt.box.shop > 0 THEN
   3481    shop txt.box.shop - 1
 ->3482   ELSEIF txt.box.shop < 0 THEN
   3483    '--Preserve background for display beneath the top-level shop menu
@ main + 0x35fc (game.exe)
@ [game.exe + 0x126d]
@ __RtlUserThreadStart + 0x2f (ntdll.dll)
@ _RtlUserThreadStart + 0x1b (ntdll.dll)
```

(The unmarked frame at the top is in fb_StrAssign: I believe it's crashing due to heap or stack corruption)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/11#issuecomment-523726700
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20190821/c303e54d/attachment.html>