<p>Definitely a release-blocker... not just because it turns out that it causes crashes in a number of games.</p>
<p>Have three crash reports for this (4445d2bf, d48c50da, 2e5ba8cd), all with identical backtrace:</p>
<pre><code>----- Stacktrace -----
@ [game.exe + 0x1e497c]
@ [game.exe + 0x1e3605]
@ SELLSTUFF (menustuf.rbas:1770 + 0x28)
1768 ELSE
1769 item_name = inventory(i).text
->1770 END IF
1771 printstr item_name, 20 + 96 * (i MOD 3), 12 + 8 * ((i - top) \ 3), page
@ SHOP (moresubs.rbas:1650 + 0x15)
1648 IF menuid(st.pt) = 1 THEN '--SELL
1649 sellstuff id, storebuf()
->1650 END IF
1651 IF menuid(st.pt) = 2 THEN '--HIRE
@ ADVANCE_TEXT_BOX (game.bas:3482 + 0x9)
3480 IF txt.box.shop > 0 THEN
3481 shop txt.box.shop - 1
->3482 ELSEIF txt.box.shop < 0 THEN
3483 '--Preserve background for display beneath the top-level shop menu
@ main + 0x35fc (game.exe)
@ [game.exe + 0x126d]
@ __RtlUserThreadStart + 0x2f (ntdll.dll)
@ _RtlUserThreadStart + 0x1b (ntdll.dll)
</code></pre>
<p>(The unmarked frame at the top is in fb_StrAssign: I believe it's crashing due to heap or stack corruption)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ohrrpgce/ohrrpgce/issues/11?email_source=notifications&email_token=AMWGWZRSIOXKYEKT7YARWODQFX6K3A5CNFSM4H7GZSF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD43W63A#issuecomment-523726700">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AMWGWZUBMWDNHFWCZ4OFIPTQFX6K3ANCNFSM4H7GZSFQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AMWGWZTJPLHWNNOIIWS6CUTQFX6K3A5CNFSM4H7GZSF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD43W63A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ohrrpgce/ohrrpgce/issues/11?email_source=notifications\u0026email_token=AMWGWZRSIOXKYEKT7YARWODQFX6K3A5CNFSM4H7GZSF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD43W63A#issuecomment-523726700",
"url": "https://github.com/ohrrpgce/ohrrpgce/issues/11?email_source=notifications\u0026email_token=AMWGWZRSIOXKYEKT7YARWODQFX6K3A5CNFSM4H7GZSF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD43W63A#issuecomment-523726700",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>