[Ohrrpgce] [ohrrpgce:bugs] #2031 Hero slices are associated with caterpillar ranks rather than heroes

[Bob the Hamster]

I was thinking about this more, and I mis-spoke. havign slices exist for empty caterpillar slots isn't neccisarily intended, and it isn't behavior that needs to be preserved if it causes other problems.

What definitely is intended behavior is being able to set the X, Y, Z and direction of empty hero slots. That data is currently stored in the cats() array of CaterpillarHistory objects, and it just gets copied into the hero slices.

So if removing the unused hero slices is the best thing to do, I retract my objection.

> ...Is it much of a burden to have to check whether the slice exists?

No, I don't think it is a burden

> ...Or github or bitbucket. Oh, and now this text input field has broken on me too...

How about we abandon sourceforge, and use the github issue tracker? I already have one here:
https://github.com/bob-the-hamster/ohrrpgce/issues

Since we only have 16 open bugs here, it would not be that big a deal to copy-paste them over there.


---

** [bugs:#2031] Hero slices are associated with caterpillar ranks rather than heroes**

**Status:** open
**Milestone:** OHRRPGCE
**Created:** Mon Jan 22, 2018 03:02 PM UTC by TeeEmCee
**Last Updated:** Mon Jan 22, 2018 03:38 PM UTC
**Owner:** nobody


Hero slices act rather weird. Slices are assigned to heroes based on their rank. If their rank changes (due to add, delete or swap of heroes) then their slices get reassigned, and the sprites and positions updated to match the hero. But any other slices you've parented to the hero slice will suddenly be parented to a different hero.

Closely related, there are always 4 hero slices regardless of the number of heroes in the active party. I know this has tripped people up, for example, it's very unexpected for "find slice at point" to find a hero that doesn't exist. I intend to mark these slices as template slices to reduce those problems. But it would be better to get rid of them.

Both changes would need a backcompat bit. (It would be the same one)

Also, I think it would be good if hero slices were preserved even when a hero is in the reserve party, so that you don't need to re-stepup slices when the party changes (in future I expect they will be preserved in saved games like other slice) and so that they can be used in future in the Party special screen or other uses.
It's perfectly legal to have slices disconnected from the slice tree, but that creates so many possible edgecases. A safer solution is probably to have a special hidden toplevel slice in the slice tree for storing "disconnected" slices.


---

Sent from sourceforge.net because ohrrpgce at lists.motherhamster.org is subscribed to https://sourceforge.net/p/ohrrpgce/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/ohrrpgce/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20180123/fe333937/attachment.html>