[Ohrrpgce] [ohrrpgce:bugs] Re: #2031 Hero slices are associated with caterpillar ranks rather than heroes

[TeeEmCee]

Maybe we should create an 'ohrrpgce' organisation on GH. Then the URL would be https://github.com/ohrrpgce/ohrrpgce/
This could become the official mirror of the svn repo, or the official repo if we ever switch from svn to git. That way you can continue having your own repo on github. Although the svn-mirroring script could push into a repo with additional non-svn branches.

GH has an API for their issue tracker, although it's pretty primitive, so you can't import a lot of stuff... like authors of comments :/ so people have of course written conversion tools. There are a bunch of alternatives. I would really like to import all our old bugzilla bugs, because there's a heap of important information there (which I can thankfully still access in my email archives)

sourceforge to gh: https://github.com/cmungall/gosf2github
bugzilla to gh: https://www.theozimmermann.net/2017/10/bugzilla-to-github
https://stackoverflow.com/questions/7281304/migrate-bugzilla-issues-to-github-issue-tracker

Example of an issue converted from bugzilla:  https://github.com/coq/coq/issues/2000
It's not very pretty. I suspect this is something bitbucket does better (because Atlassian are also the authors of JIRA)

We can make sure that issue numbers on GH and Bugzilla are identical. It doesn't seem to be possible to skip over numbers, unlike SF, unless we were to add a thousand dummy issues. But because we have so few bugs on SF it doesn't matter if we renumber those.
Also, I believe there's no way to delete an issue and reassign the number, so any attempt to import had better be correct on the first try! Better test on a dummy repo.

I would be willing to figure out the scripts to migrate from SF and Bugzilla.


---

** [bugs:#2031] Hero slices are associated with caterpillar ranks rather than heroes**

**Status:** open
**Milestone:** OHRRPGCE
**Created:** Mon Jan 22, 2018 03:02 PM UTC by TeeEmCee
**Last Updated:** Tue Jan 23, 2018 03:25 PM UTC
**Owner:** nobody


Hero slices act rather weird. Slices are assigned to heroes based on their rank. If their rank changes (due to add, delete or swap of heroes) then their slices get reassigned, and the sprites and positions updated to match the hero. But any other slices you've parented to the hero slice will suddenly be parented to a different hero.

Closely related, there are always 4 hero slices regardless of the number of heroes in the active party. I know this has tripped people up, for example, it's very unexpected for "find slice at point" to find a hero that doesn't exist. I intend to mark these slices as template slices to reduce those problems. But it would be better to get rid of them.

Both changes would need a backcompat bit. (It would be the same one)

Also, I think it would be good if hero slices were preserved even when a hero is in the reserve party, so that you don't need to re-stepup slices when the party changes (in future I expect they will be preserved in saved games like other slice) and so that they can be used in future in the Party special screen or other uses.
It's perfectly legal to have slices disconnected from the slice tree, but that creates so many possible edgecases. A safer solution is probably to have a special hidden toplevel slice in the slice tree for storing "disconnected" slices.


---

Sent from sourceforge.net because ohrrpgce at lists.motherhamster.org is subscribed to https://sourceforge.net/p/ohrrpgce/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/ohrrpgce/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20180124/216b67ba/attachment.html>