[Ohrrpgce] SVN: james/9048 Touch Textboxes is now enabled for all games. (no Android ohrrpgce games

[James Paige]

That is a good plan.

I think the dubious code was a workaround for Android, but with real mouse
support in the works, what you describe sounds better.

On Saturday, July 15, 2017, Ralph Versteegen <teeemcee at gmail.com> wrote:

> This reminds me, there is one dubious use of use_touch_textboxes().
> waitforkey waits for a left mouse click only if txt.showing AND
> use_touch_textboxes(). (Regardless of the arg to waitforkey! That's a
> bug.)  So this means if you enable click_textboxes then you can advance
> waitforkey only if a textbox is up. But probably you want to advance
> regardless of textboxes. So this seems rather over-complicated.
> Maybe we should just greatly simplify and always make waitforkey(anykey)
> and waitforkey(usekey) accept a mouse click (any button and left button
> respectively)? The onkeypress script is already called for mouse clicks if
> initmouse was called. The only games that would be affected would be ones
> that call waitforkey to wait for a keyboard key while simultaneously
> processing mouse input using an onkeypress/timer script. Which seems highly
> unlikely.
>
> On 15 July 2017 at 19:38, James Paige <Bob at hamsterrepublic.com
> <javascript:_e(%7B%7D,'cvml','Bob at hamsterrepublic.com');>> wrote:
>
>> Normally I would have written some upgrade code to preserve the old
>> setting when converting from a bool stored in reload as an absent/present
>> to a 0/1 integer but in the case of this specific key, it should definitely
>> be on for all games.
>>
>> I did toy with the idea of deleting the key entirely, but I decided to
>> retain the ability to turn it off, just in case somebody thinks of a solid
>> reason to want to do that in the future.
>>
>> On Sat, Jul 15, 2017 at 5:34 PM, <subversion at hamsterrepublic.com
>> <javascript:_e(%7B%7D,'cvml','subversion at hamsterrepublic.com');>> wrote:
>>
>>> james
>>> 2017-07-15 17:34:20 -0700 (Sat, 15 Jul 2017)
>>> 374
>>> Touch Textboxes is now enabled for all games. (no Android ohrrpgce games
>>> currently exist that will be broken by this change)
>>>
>>> Previously this option was handled by the presence or absence of
>>> /mobile_options/touch_textboxes which as we previously agreed is a
>>> terrible way of storing booleans
>>> Now it is stored in /mobile_options/touch_textboxes/enabled which
>>> defaults to true.
>>> ---
>>> U   wip/common.rbas
>>> U   wip/customsubs.rbas
>>> U   wip/moresubs.rbas
>>> _______________________________________________
>>> Ohrrpgce mailing list
>>> ohrrpgce at lists.motherhamster.org
>>> <javascript:_e(%7B%7D,'cvml','ohrrpgce at lists.motherhamster.org');>
>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>
>>
>>
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> <javascript:_e(%7B%7D,'cvml','ohrrpgce at lists.motherhamster.org');>
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20170716/a30aeca8/attachment.htm>