[Ohrrpgce] SVN: james/12685 Fix "Jump" (and the other new hiding attacks) to properly prevent target

[James Paige]

Yeah, I like the idea of a separate bit to allow an attack to target hidden.

I wish we had thought of that for "including dead", but oh well! :D

On Sat, Jan 15, 2022 at 11:56 PM Ralph Versteegen <teeemcee at gmail.com>
wrote:

> Of course maybe rather than adding even more target classes (a complete
> set would nearly double the current number!) we should just add a setting
> for whether hidden targets are valid.
>
> On Sun, 16 Jan 2022 at 17:51, Ralph Versteegen <teeemcee at gmail.com> wrote:
>
>> It took me some code inspection to work out that this is bug 1120
>> https://github.com/ohrrpgce/ohrrpgce/issues/1120 "Heroes which have
>> jumped/in midair count as dead for targetting" (which I renamed to
>> something more generic before realising it's fixed). So it affects only
>> attacks that can hit dead targets (which are always heroes), not attacks by
>> heroes.
>>
>> Previously, attacks which can target all combatants or all heroes
>> (especially spread attacks) could also hit jumped targets, not anymore
>> after this fix. That seems like a big change; I suggest we add a back
>> compat bit. Also, I think we really need some target classes for hitting
>> hidden targets. We could also change the description of some of the
>> existing ones to say that they can hit hidden targets, e.g. "All including
>> dead & hidden", which I did last time I realised the names were inaccurate.
>>
>> On Sun, 16 Jan 2022 at 04:15, <subversion at hamsterrepublic.com> wrote:
>>
>>> james
>>> 2022-01-15 07:15:38 -0800 (Sat, 15 Jan 2022)
>>> 96
>>> Fix "Jump" (and the other new hiding attacks) to properly prevent
>>> targetting when used by heroes
>>> ---
>>> U   wip/bmodsubs.bas
>>> U   wip/whatsnew.txt
>>>
>>> _______________________________________________
>>> Ohrrpgce mailing list
>>> ohrrpgce at lists.motherhamster.org
>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>
>> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20220116/4904da0b/attachment-0001.html>