[Ohrrpgce] New feature: Achievements

[James Paige]

I pulled the achievements branch, and looked at the code changes, and I can
get it to compile... but I can't find anything in custom about it. Where
should I be looking? What menu are achievements under?

---
James Paige

On Thu, Nov 18, 2021 at 10:14 AM Mike Caron <caron.mike at outlook.com> wrote:

> > there are still lots more things that can be done after this is merged
> (you didn't really list them so I will), including our own non-Steam
> display of achievements, an editor, script commands (as an alternative to
> toggling tags), and debug facilities.
>
>
>
> Yes, you are correct. As it is right now, you have to manually construct
> the achievement lump to get it to work. I figured that this is the absolute
> minimum amount of work to make it viable to merge.
>
>
>
> > but I did notice that Steam.run_frame still contains ACH_WIN_ONE_GAME
> test code
>
>
>
> Whoops!
>
>
>
> > and a lot of commented out C++ that probably doesn't need to be there
> anymore
>
>
>
> That was left on purpose, but I suppose it doesn’t really need to be there
> now that we’re sure the signatures are correct.
>
>
>
> > and also run_frame is not really being called from the right place: it
> will be called from 0 to 200 times a second depending on how much idle time
> is available. Should it be called more often than whatever the game's
> framerate (likely 18fps) is?
>
>
>
> Really? I put it there since that’s when we invoke the graphics backend.
> Is there a better place to put it?
>
>
>
> (I don’t think it needs to be called all that often, but this is the
> closest thing we have to a main loop, as far as I can tell)
>
>
>
> --
>
> Mike Caron
>
>
>
> *From: *Ralph Versteegen <teeemcee at gmail.com>
> *Sent: *November 18, 2021 8:58
> *To: *ohrrpgce <ohrrpgce at lists.motherhamster.org>
> *Subject: *Re: [Ohrrpgce] New feature: Achievements
>
>
>
> Great, at last!
>
> I can't believe that I thought (long ago) that this would be a
> straightforward thing to add since it's "just" calling an external API...
> there are still lots more things that can be done after this is merged (you
> didn't really list them so I will), including our own non-Steam display of
> achievements, an editor, script commands (as an alternative to toggling
> tags), and debug facilities.
>
>
>
> One thing it would be good to get other people's opinion on: there's
> currently a global flag to switch between permanent achievements (the only
> sort supported by Steam) or per-game/save ones. Would anyone ever want to
> mix the two? Consider that non-permanent ones won't be shown with the steam
> overlay.
>
>
>
> I didn't have time tonight to look over and write comments on the code,
> but I did notice that Steam.run_frame still contains ACH_WIN_ONE_GAME test
> code, and a lot of commented out C++ that probably doesn't need to be there
> anymore, and also run_frame is not really being called from the right
> place: it will be called from 0 to 200 times a second depending on how much
> idle time is available. Should it be called more often than whatever the
> game's framerate (likely 18fps) is?
>
>
>
> On Thu, 18 Nov 2021 at 18:35, Mike Caron <caron.mike at outlook.com> wrote:
>
> Naturally, I forget to include a link to the Pull Request. I have been a
> professional for a decade now 😄
>
>
>
> https://github.com/ohrrpgce/ohrrpgce/pull/1229
>
>
>
> Mike Caron
>
>
>
>
>
> *From:* Ohrrpgce <ohrrpgce-bounces at lists.motherhamster.org> on behalf of
> Mike Caron <caron.mike at outlook.com>
> *Sent:* November 18, 2021 5:33 AM
> *To:* ohrrpgce at lists.motherhamster.org <ohrrpgce at lists.motherhamster.org>
> *Subject:* [Ohrrpgce] New feature: Achievements
>
>
>
> Hello friends,
>
>
>
> As I mentioned a few weeks ago, I was working on support for Steam
> achievements in the OHRRPGCE. Well, the fateful day has come when I think
> it's ready to release to the wild.
>
>
>
> But, that said, I haven't contributed anything for a while, so I wanted to
> give you guys a chance to review my work before merging it in. So, I've
> opened up a Pull Request on GitHub and I would welcome any feedback that
> anyone would like to provide. Don't hold back! I can take it!
>
>
>
> Cheers!
>
>
>
> Mike Caron
>
>
>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20211118/9523ff7d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: E7789D4F42224BE399CD92EF35D928FD.png
Type: image/png
Size: 144 bytes
Desc: not available
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20211118/9523ff7d/attachment.png>