[Ohrrpgce] [ohrrpgce/ohrrpgce] key stuck if window focus changed when launching an external program with spawn_and_wait() (#932)

[Ralph Versteegen]

I completely forgot that we have a workaround in `spawn_and_wait`, added in 2017 in commit r9480 (d5effc884c1) to call `waitforkeyrelease` before spawning. The commit says: "This is done in all cases on all OSes, but it's mainly targetted at Windows with gfx_sdl, where it really does fix stuck keys." But... maybe that message was mistaken, as this bug report only mentions gfx_directx getting stuck keys on Windows.

As much as I have the memory of gfx_sdl on Windows suffering stuck keys when spawning programs, I can't actually find that on the bug list. It looks more like it was a problem on Linux, not Windows. We didn't and don't file everything here, though.

Anyway I tried commenting out the `waitforkeyrelease`s and tested spawning hspeak or oggenc with gfx_sdl or gfx_directx on Linux and Windows and couldn't reproduce any problems! gfx_directx hasn't been using in Custom for a number of years anyway.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/932#issuecomment-762704875
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20210119/052dd8c6/attachment.html>