<p></p>
<p>I completely forgot that we have a workaround in <code>spawn_and_wait</code>, added in 2017 in commit r9480 (<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/ohrrpgce/ohrrpgce/commit/d5effc884c1201c953e293390a1ea60a5edb974b/hovercard" href="https://github.com/ohrrpgce/ohrrpgce/commit/d5effc884c1201c953e293390a1ea60a5edb974b"><tt>d5effc8</tt></a>) to call <code>waitforkeyrelease</code> before spawning. The commit says: "This is done in all cases on all OSes, but it's mainly targetted at Windows with gfx_sdl, where it really does fix stuck keys." But... maybe that message was mistaken, as this bug report only mentions gfx_directx getting stuck keys on Windows.</p>
<p>As much as I have the memory of gfx_sdl on Windows suffering stuck keys when spawning programs, I can't actually find that on the bug list. It looks more like it was a problem on Linux, not Windows. We didn't and don't file everything here, though.</p>
<p>Anyway I tried commenting out the <code>waitforkeyrelease</code>s and tested spawning hspeak or oggenc with gfx_sdl or gfx_directx on Linux and Windows and couldn't reproduce any problems! gfx_directx hasn't been using in Custom for a number of years anyway.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ohrrpgce/ohrrpgce/issues/932#issuecomment-762704875">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AMWGWZUUAEN3R6MQUITUNYTS2VDXVANCNFSM4RJUVJTA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AMWGWZUEAQDY7GONSDUH22DS2VDXVA5CNFSM4RJUVJTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFV27H2Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ohrrpgce/ohrrpgce/issues/932#issuecomment-762704875",
"url": "https://github.com/ohrrpgce/ohrrpgce/issues/932#issuecomment-762704875",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>