[Ohrrpgce] attacksounds branch?

[Ralph Versteegen]

Oh! Turns out that that commit did every except actually add the menu items
to the menu, so there was no reason I couldn't have committed it already.
(I prefer to put related commits next to each other, which is why I
sometimes hold back commits that are done but don't do anything yet).

Yes, looks like the attack editor work is complete. I removed the binsize
bump from the commit, since you'll do that.
Would be nice if you finished it.

On Sun, 19 Jul 2020 at 00:09, James Paige <Bob at hamsterrepublic.com> wrote:

> Merging it with the menus commented out is totally reasonable. Is making
> the sounds play in battle the only thing that is missing? Maybe I can
> finish that part myself after I finish attack alignment
>
> On Sat, Jul 18, 2020, 2:58 AM Ralph Versteegen <teeemcee at gmail.com> wrote:
>
>> I'm kind of surprised to see you actually looked through my branches!
>>
>> It wasn't merged of course because it's not done, and it's probably not
>> done because I got distracted with something else. I don't want to add the
>> settings to the attack editor before they actually do anything.
>> Finishing that is listed near the top of my todo list, but I'm not going
>> to get to it soon.
>> How about I merge it, but comment out the menu items in the editor. That
>> would stop it rotting.
>>
>> On Sat, 18 Jul 2020 at 12:17, James Paige <Bob at hamsterrepublic.com>
>> wrote:
>>
>>> Hello, TMC!
>>>
>>> Was there any reason why the Attack Sounds branch was never merged?
>>> https://bitbucket.org/rbv/ohrrpgce/commits/branch/attacksounds
>>>
>>> I plan to work on attack alignment this weekend, and I will be leaving
>>> the data used by the attack sounds feature as "reserved" but the work I
>>> commit this weekend is likely to bit-rot that branch further than it may
>>> already be
>>>
>>> ---
>>> James
>>> _______________________________________________
>>> Ohrrpgce mailing list
>>> ohrrpgce at lists.motherhamster.org
>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20200719/d6294fe0/attachment.html>