[Ohrrpgce] [ohrrpgce/ohrrpgce] Enemies using on-death bequest attacks fade out twice (#43)

[Ralph Versteegen]

If an enemy has an on-death bequest attack and that attack doesn't cancel the enemy's death (by healing or transmogrifying itself), then the enemy's dissolve animation restarts from the beginning, effectively playing twice. The start of the fade out needs to be delayed until after on-death attacks are handled.

Also, I happened across an interesting comment. As an email reply to r7885, which was:
> Call fulldeathcheck() inside active_mode_state_machine()
> This fixed a bug where you could get stuck with a hero who could not target any enemy when
> all enemies die at once and trie to do death-bequest-attacks on each other."

James wrote on 1 Apr 2016:
> Oh, by the way, this also appears to fix the double-dissolve when an enemy is doing an on-death-bequest attack.

However r7885 introduced a bug:
> I just realized that this fix breaks the even more common case of on-death-bequest attacks that target the dying enemy to transmogrify them into something else.

This bug was fixed in r8084. I wonder whether r8084 reintroduced the double-fade?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20200125/9b69a6eb/attachment.html>