[Ohrrpgce] SVN: james/11388 Detect, and visible_debug an array-out-of-bounds access in interpolateca

Ralph Versteegen teeemcee at gmail.com
Sat Nov 9 17:05:32 PST 2019


While "set hero speed" disallows negative speed, "alter npc" does almost no
validity checking! And we generally don't check data files contain valid
data either.

On Sun, 10 Nov 2019 at 13:19, James Paige <Bob at hamsterrepublic.com> wrote:

> *cough, mumble*
>
> Because I forgot about showbug. I'll fix it :)
>
> Do we allow negative speed anywhere? If negative speed works, and makes
> you walk backwards or something, my head might explode ;)
>
> ---
> James
>
> On Sat, Nov 9, 2019 at 7:08 PM Ralph Versteegen <teeemcee at gmail.com>
> wrote:
>
>> Well why not showbug instead of visible_debug then?
>>
>> It looks like this could only have happened if old_speed was negative. If
>> it was zero I think you would get a division by zero error instead.
>>
>> On Sun, 10 Nov 2019 at 11:50, James Paige <Bob at hamsterrepublic.com>
>> wrote:
>>
>>> I have only seen this array-out-of-bounds access happen once, while I
>>> was button-mashing in my first playthrough of breakout.rpg for the
>>> Halloween contest.
>>>
>>> No matter how hard I tried, I couldn't reproduce it again, but it did
>>> definitely happen.
>>>
>>> I figure this change makes it easier for someone else to see it and
>>> report when it occurs.
>>>
>>> Will I regret this choice?
>>>
>>> The chances are always non-zero ;)
>>>
>>> ---
>>> James
>>>
>>>
>>> On Sat, Nov 9, 2019 at 5:47 PM <subversion at hamsterrepublic.com> wrote:
>>>
>>>> james
>>>> 2019-11-09 14:47:33 -0800 (Sat, 09 Nov 2019)
>>>> 73
>>>> Detect, and visible_debug an array-out-of-bounds access in
>>>> interpolatecat
>>>> ---
>>>> U   wip/game.bas
>>>> _______________________________________________
>>>> Ohrrpgce mailing list
>>>> ohrrpgce at lists.motherhamster.org
>>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>>
>>> _______________________________________________
>>> Ohrrpgce mailing list
>>> ohrrpgce at lists.motherhamster.org
>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20191110/853cc431/attachment.html>


More information about the Ohrrpgce mailing list