[Ohrrpgce] Android build problem

[Ralph Versteegen]

I know that there were other reasons to use a newer NDK, but I don't
remember what they are. I'm not bothered by it right now. A newer NDK
would also increase our min supported Android version, I think? But I
had to actually look up what it was (Android 2.3), because I'd
forgotten. It wouldn't be bad if we had to bump the requirement
slightly to Android 4.0.3 but I wouldn't want to go beyond that.

That ambiguous call error is an odd one, it took me a few minutes to
realise what it is. It's because integer constants are 64 bit in 64
bit builds, and converting an int64 to a double is a narrowing
conversion - converting a double to an in64 is also a narrowing
conversion (ie, potentially loses information). So the compiler isn't
sure which way to go.

On Mon, 11 Mar 2019 at 22:42, James Paige <Bob at hamsterrepublic.com> wrote:
>
> Ah, I see. Is it worth us try to switch to a newer NDK?
>
> I also just noticed that the 64 but linux builds have been failing since last Wednesday. They say:
>
> slices.bas(1788) error 97: Ambiguous call to overloaded function, LARGE() in 'out_surf = surface_scale(in_surf, large(1, spr->w * .zoom), large(1, spr->h * .zoom))'
> scons: *** [build/game-slices.o] Error 1
>
> On Monday, March 11, 2019, Ralph Versteegen <teeemcee at gmail.com> wrote:
>>
>> Oh, that's not hard to fix.
>> But I notice that the versions of GCC used in the NDK versions you and
>> I are using don't support C++11 designated initializer syntax; we use
>> a GCC extension syntax instead. So it's not a C++11-compliant
>> compiler, a nuisance.
>>
>> On Mon, 11 Mar 2019 at 07:15, James Paige <Bob at hamsterrepublic.com> wrote:
>> >
>> > For the past week the Android build has been broken as a consequence of me finally checking in the change to increase minSdkVersion without alos installing the needed SDK package on the nightly build machine.
>> >
>> > However, when I went to fix that today I realized there is a new build failure on Android that happens first:
>> >
>> > jni/../jni/application/ohrrpgce/tmp/surface.cpp: In function 'int gfx_surfaceCreatePixelsView_SW(void*, int, int, int, SurfaceFormat, Surface**)':
>> > jni/../jni/application/ohrrpgce/tmp/surface.cpp:99:2: sorry, unimplemented: non-trivial designated initializers not supported
>> > make: *** [obj/local/armeabi/objs-debug/application/ohrrpgce/tmp/surface.o] Error 1
>> > _______________________________________________
>> > Ohrrpgce mailing list
>> > ohrrpgce at lists.motherhamster.org
>> > http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org