[Ohrrpgce] SVN: james/10193 Add a .by_user member to the HeroPathing object and use it to distinguis

[Ralph Versteegen]

I'm a bit concerned by:

+   IF rank = 0 ANDALSO gam.hero_pathing(rank).by_user THEN
+    'Only the leader activates NPCs, and only when doing built-in user
pathing

Other commands for scripted hero movement don't have any affect on
touch-NPC activation. And I assume pathing a touch-activated NPC past the
hero doesn't prevent its activation either. Why should hero pathfinding be
exceptional? If people don't want touch activation to occur, they could
explicitly suspend that activation instead*.
And anyway, you only disabled the touch-NPC-activation check in
update_hero_pathfinding, but didn't disable the check in the NPC movement
code.

* In fact, there is no command to suspend NPC activation, except for
"suspend obstruction" and "set npc usable"! The lack of a "suspend npc
activation" command is a pretty huge oversight.

On 27 March 2018 at 11:15, <subversion at hamsterrepublic.com> wrote:

> james
> 2018-03-26 15:15:12 -0700 (Mon, 26 Mar 2018)
> 217
> Add a .by_user member to the HeroPathing object and use it to distinguish
> between built-in user pathing and scripted hero pathing
> Options to cancel pathing on textbox, menus, and battles only apply when
> .by_user = YES
> ---
> U   wip/game.bas
> U   wip/game.bi
> U   wip/game_udts.bi
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20180327/710d4d72/attachment-0001.html>