[Ohrrpgce] SVN: teeemcee/9931 Fix two bugs involving textbox 'after' links, one quite nasty.

subversion at HamsterRepublic.com subversion at HamsterRepublic.com
Mon Jan 1 06:55:47 PST 2018


teeemcee
2018-01-01 06:55:47 -0800 (Mon, 01 Jan 2018)
953
Fix two bugs involving textbox 'after' links, one quite nasty.

In the textbox editor, pressing Ctrl+Left/Right to link to another box appeared
to work but actually the "After" tag condition didn't get set to "Always",
although it claimed it was. It didn't actually get set to "Always" until you
entered a submenu. The textbox editor doesn't save when you exit (instead, its
meant to save when data is edited), so it's possible that what appears to be the
state of the textbox never makes it to disk.
Reported by Taoki.

The in-game F1 textbox debug screen also showed "ALWAYS" instead of "NEVER"
(this only affected the After box/script option; tags aren't shown for other
conditionals), which made this bug even more confusing.

The bug was that these lines of code were in the wrong order:
       SaveTextBox box, st.id
       update_textbox_editor_main_menu box, menu()
but to make this less confusing I instead split out "textbox_set_after_textbox"
---
U   wip/game.bas
U   wip/textboxedit.bas
U   wip/whatsnew.txt


More information about the Ohrrpgce mailing list