[Ohrrpgce] Any recently fixed bugs that could write lumps into the C:\ root?

Ralph Versteegen teeemcee at gmail.com
Wed Nov 22 17:36:57 PST 2017


On 23 November 2017 at 14:34, Ralph Versteegen <teeemcee at gmail.com> wrote:

> I think the datestamp would be related to r9047 (July 15) "Include
> data/defaultgfx/ in the Innosetup script."
>
> Ah, I have a zero-length defpal7.bin file located at ../defpal7.bin,
> relative to my git (wip) directory. Is that also true for yours? It's dated
> April 23th.
> But I can't see any way that a file could have been written to ../.
> However, anything written to \ would be written to the drive root on
> Windows.
> It looks like r8660 (April 20th) fixed a bug that would have created
> defpal7.bin in the root directory. I'm guessing that the July 15 time stamp
> on yours is due to not using the latest svn revision at the time, or
> something like that.
>
> We really need to get into the habit of always opening files with
> ACCESS_READ when we don't want to create them.
>

Would also be nice to be explicit about wanting to write a file (this lets
OPENFILE know, so that it can catch errors when you do this while Testing
Game). Just remember that you need to use ACCESS_READ_WRITE if you don't
want to delete the existing file!

>
> On 23 November 2017 at 09:10, James Paige <Bob at hamsterrepublic.com> wrote:
>
>> I just noticed that on my Windows nightly build vm, I have a zero-byte
>> C:\defpal7.bin file.
>>
>> The file date is July 15 2017
>>
>> I didn't see anything obviously related in the git log. Maybe it has
>> something to do with drawing box borders before an rpg file has been opened?
>>
>> I would have guessed that maybe r8700 was relevant "Don't use box borders
>> in Game before loading a game; data/ isn't available" but that is from
>> April 28th,
>>
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20171123/8f41d535/attachment-0001.html>


More information about the Ohrrpgce mailing list