[Ohrrpgce] SVN: teeemcee/9086 Add describe_tag_condition() and cleanup base_tag_caption() in customsub

[James Paige]

I totally agree with both:

A) it is better to have a bunch of different functions for different
clients rather than one general-for-the-sake-of-generality function that
tries to do everything

B) maybe one or two of those might be redundant and removable

On Wednesday, July 26, 2017, <subversion at hamsterrepublic.com> wrote:

> teeemcee
> 2017-07-26 04:58:04 -0700 (Wed, 26 Jul 2017)
> 635
> Add describe_tag_condition() and cleanup base_tag_caption() in
> customsubs...
>
> We now have describe_tag_condition, explain_two_tag_condition,
> tag_{condition,toggle,choice,set}_caption, textbox_condition_caption and
> textbox_condition_short_caption, which all format tag conditions in
> slightly
> different ways!! And only describe_tag_condition is available in Game.
> Oh, what a mess. But it turns out that we really do want
> different formatting in different places. And creating one super-general
> function which takes 10 arguments is not a good solution. However, maybe
> the number of ways of displaying tag conditions could be reduced a bit
> ---
> U   wip/common.bi
> U   wip/common.rbas
> U   wip/customsubs.bi
> U   wip/customsubs.rbas
> U   wip/mapsubs.bas
> U   wip/textboxedit.bas
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org <javascript:;>
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20170726/ab28a312/attachment-0001.htm>