<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jan 28, 2022 at 9:55 AM Ralph Versteegen <<a href="mailto:teeemcee@gmail.com">teeemcee@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 28 Jan 2022 at 16:46, James Paige <<a href="mailto:Bob@hamsterrepublic.com" target="_blank">Bob@hamsterrepublic.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jan 27, 2022 at 7:01 PM Ralph Versteegen <<a href="mailto:teeemcee@gmail.com" target="_blank">teeemcee@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 17 Jan 2022 at 03:53, James Paige <<a href="mailto:Bob@hamsterrepublic.com" target="_blank">Bob@hamsterrepublic.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jan 15, 2022 at 11:25 PM Ralph Versteegen <<a href="mailto:teeemcee@gmail.com" target="_blank">teeemcee@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Nice! Just what was always missing.<br></div><div><br></div><div>I think that the name "Run In (unhides attacker)" which you used at first was better than "Unhide", because it does more than just unhiding. Plus I think that when the attack editor gets cleaned up the Always Hide/Unhide options would be placed right below the attack animation option, so "Attacker animation: Unhide" "Unhide attacker: YES" would be odd.<br></div></div></blockquote><div><br></div><div>Good point. I'll rename it back to "Run In"<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div><br></div><div>I noticed some glitches (bug #1234) but they're shared with Jump, so no new problem there.<br></div><div><br></div><div>I was hoping that adding BattleSprite.hidden meant some code cleanup occurred, but I see you dodged the issue (something I should learn to do) and just added it in addition to the .vis mess. Which means that the following comment change you made is not correct (or at least, removes truth)<br></div></div></blockquote><div><br></div><div>You caught me! Okay, I went back and did the bare minimum of cleanup to make my change to that comment accurate :D</div></div></div></blockquote><div><br></div><div>This (r12690) really is some nice cleanup, disentangling .hidden from .vis. But did you check everywhere that .vis was used to see they should check .hidden?</div></div></div></blockquote><div><br></div><div>No I didn't check everywhere, could have missed other spots too<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> In particular, I noticed that targenemycount checks just .vis, so that has some significant consequences: previously if all an enemies jumped it would count as being Alone, now not. I'm not sure if that's a bug or a feature, maybe it needs a backcompat or preference bit.</div></div></div></blockquote><div><br></div><div>I think the old behavior was a bug. Definitely unintentional.<br></div></div></div></blockquote><div><br></div><div>I agree, but maybe I'll add a pref bit anyway, since it's easy to do so, and could be useful.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> More significantly battle_meters_can_advance and turn_mode_time_passage now don't advance time if all targets are hidden, which is game breaking.</div></div></div></blockquote><div><br></div><div>Oop! Yeah, that one sounds important to fix!</div><div>Hmmm. does that mean it would only break when all heroes and all enemies jumped at the same time? That would be rare.</div><div>Either way, I have added it to my todo list to test and fix<br></div></div></div></blockquote><div><br></div><div>To hit the issue you only need all enemies to jump. Which is easy if there's just one.</div></div></div></blockquote><div><br></div><div>Did you already do something to fix this one?</div><div>I can't reproduce this in either active-time or turn-based combat. When there is a single enemy, and it jumps, time flows normally as expected<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div>Completely separately to .vis vs .hidden, targenemycount also hasn't been updated for turncoat and defector. In some places it's used to count allies, in others to count foes.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> Also I noticed reset_enemy_state doesn't reset .hidden, so transmog used to undo Jump, but now it doesn't. Also a bug-feature? I didn't go through all uses of .vis.<br></div></div></div></blockquote><div><br></div><div>I didn't realize that transmog used to reset jump. I guess I had never tested transmog mid-jump-- but I would consider the new behavior a bugfix. I did intentionally avoid resetting hidden on transmogrification, figuring that sometimes you would want an enemy to hide, and then return in a different form.<br></div></div></div></blockquote><div><br></div><div>I agree that it's better that transmog doesn't unhide. But we should at least try to document all these changes as bugfixes in whatsnew.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div><br></div><div>I better review all of the .vis uses just to be complete.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div> vis as bool 'Roughly, but not exactly, visibility:<br> 'For combatants: Is alive (or dying interruptted) and visible (didn't jump).<br> ' Gets set to YES while an enemy is performing an on-death attack.</div><div>- ' Gets set to NO while it's dissolving or fleeing after death, or<br>- ' or if jumped off-screen<br>+ ' Gets set to NO while it's dissolving or fleeing after death</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 16 Jan 2022 at 04:15, <<a href="mailto:subversion@hamsterrepublic.com" target="_blank">subversion@hamsterrepublic.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">james<br>
2022-01-15 07:15:33 -0800 (Sat, 15 Jan 2022)<br>
279<br>
Add attacker animations "Run and Hide" and "Unhide" that work like "Jump" and "Land"<br>
<br>
Add bitsets that allow other attacks to hide/unhide attackers, regardless of their attacker animations<br>
<br>
Add a .hidden member to the BattleSprite type, instead of overloading the meaning of .vis<br>
---<br>
U wip/attackedit.bas<br>
U wip/<a href="http://battle_udts.bi" rel="noreferrer" target="_blank">battle_udts.bi</a><br>
U wip/<a href="http://bmod.bi" rel="noreferrer" target="_blank">bmod.bi</a><br>
U wip/bmod.rbas<br>
U wip/bmodsubs.bas<br>
U wip/loading.rbas<br>
U wip/<a href="http://udts.bi" rel="noreferrer" target="_blank">udts.bi</a><br>
<br>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div></div>