<div dir="ltr"><div>The attack editor certainly needs replacement. We shouldn't have a huge Bitsets menu; settings should be organised by function/category, not by datatype. Also, on many occasions I've put off adding new attack features (or attack editor features like previews) because of the pain of adding it to the attack editor (though I can say the same of several other menus too). Currently the editor is built on something call "flexmenu" which makes it very painful to change menu items based on other settings, such as hiding non-applicable settings. <br></div><div><br></div><div>But replacing it is really ambitious. I would do it a bit at a time rather than a single huge commit.<br></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 31 Dec 2021 at 15:47, Michael Kidder <<a href="mailto:mkidder@gmail.com">mkidder@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I've always felt the attack editor could use a freshen up, but I think my plan would be to start smaller and refactor the music browser menu first.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Dec 29, 2021 at 6:10 AM Ralph Versteegen <<a href="mailto:teeemcee@gmail.com" target="_blank">teeemcee@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Would be welcome! If you do, feel free to ask for help and more features. I'm still adding things to it every time I work on a menu (in particular new data types like "textbox id"), not to mention the more interesting things to be added like tabbed interfaces and icons.<br></div>Which editors are you interested in reworking? So far my experience is that the most work in converting an existing menu is just in refactoring the messy old code; not a problem when writing from scratch.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 29 Dec 2021 at 17:40, Michael Kidder <<a href="mailto:mkidder@gmail.com" target="_blank">mkidder@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">oooooh.. this looks very neat. i've always wanted to contribute and EditorKit looks like a good way for me to get used to working with the engine / do some new or reworked menus. Will have to look at this closer when i have time in 2022.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Nov 14, 2021 at 8:11 AM James Paige <<a href="mailto:Bob@hamsterrepublic.com" target="_blank">Bob@hamsterrepublic.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">This is great! I am delighted-- and yes, I agree, EditEdit was the wrong way to do built-in editor menus<div dir="auto"><br></div><div dir="auto">This also makes me think about other non-reload lumps that I would like to eventually convert to reload</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat., Nov. 13, 2021, 11:05 p.m. Ralph Versteegen, <<a href="mailto:teeemcee@gmail.com" target="_blank">teeemcee@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Phew, that took me at least 5x longer than expected, since starting a fortnight ago.</div><div>This is something I've always wished we had. In particular, I wanted to make it easy to create editors for RELOAD docs, such as achievements. Next up I'm converting Platform Options. There are going to be many benefits. One goal is to allow changing/improving the appearance and UI of editors, for example using different fonts (and even text encodings) for editor text and game strings.</div><div><br></div><div>I intend, over time, to rewrite almost every menu in Custom using EditorKit; I've tried to make it as flexible as possible to allow this. In contrast because Editor Editor is data-centric it's very restrictive and wouldn't be possible. I think it would still be cool to allow users to define their own data editors using editedit, but I don't think we want any builtin editors built that way.</div><div><br></div><div>The biggest things missing are support for switching records, and submenus.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 14 Nov 2021 at 16:41, <<a href="mailto:subversion@hamsterrepublic.com" rel="noreferrer" target="_blank">subversion@hamsterrepublic.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">teeemcee<br>
2021-11-13 19:41:29 -0800 (Sat, 13 Nov 2021)<br>
809<br>
Introducing EditorKit, a framework for creating data editors<br>
<br>
EditorKit is intended to be flexible enough to reimplement almost every existing<br>
editor easily with minimal code. It's flexible because menu items are defined<br>
with code, not data.<br>
<br>
It's implemented on top of standardmenu and ModularMenu, which does create some<br>
inflexibility, but they can be extended to overcome that. It's based on how the<br>
Debug Menu and General Game Data menu are implemented: you just Extend<br>
EditorKit, add a define_items() method which lists the menu items, and write<br>
some code to load/save data if needed and you're done.<br>
<br>
Currently only basic data type editing is done (except floats), plus partial<br>
set of directives config settings and RELOAD node datatypes. No special<br>
support for switching records or lists of items yet.<br>
---<br>
U wip/SConscript<br>
A wip/editorkit.bas<br>
A wip/<a href="http://editorkit.bi" rel="noreferrer noreferrer" target="_blank">editorkit.bi</a><br>
<br>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" rel="noreferrer" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" rel="noreferrer" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div>
_______________________________________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org</a><br>
</blockquote></div>