<p></p>
Oh, nice!<br>
<br>
And the workaround of fixing the checksum with an fb function is clever!<br>
<br>
If this is so close to being fixed, I'll hold off on branching hrodvitir<br>
just a little longer, but I think this is the last thing we need.<br>
<br>
I'm also going to start begging for release-candidate testing right now-- I<br>
am hoping to keep the RC testing cycle as short as reasonable possible,<br>
since I think the nightly wips are already quite stable, and + releases are<br>
not hard.<br>
<br>
---<br>
James<br>
<br>
<br>
<br>
On Sun, Sep 5, 2021 at 12:24 PM Ralph Versteegen ***@***.***><br>
wrote:<br>
<br>
> This is almost solved!<br>
><br>
> Firstly, rescanning the previous file, the number of detections dropped to<br>
> just 7/66 (including Microsoft and McAfee). But they're detecting it based<br>
> on learning from the previous false positive I think. Embedding an icon in<br>
> a fresh nightly copy of game.exe produces just 2/66 detections, from only<br>
> obscure scanners.<br>
><br>
> Looking at the rcedit issue tracker I discovered that this problem is<br>
> caused by rcedit not updating the .exe checksum, so I fixed rcedit to do<br>
> so, solving the problem! 0/66 detections.<br>
><br>
> However I compiled rcedit using Visual Studio 2019 using the "v141_xp"<br>
> toolchain which supposedly targets Windows XP. Unfortunately, it doesn't<br>
> actually<br>
> <https://developercommunity.visualstudio.com/t/visual-studio-1692-breaks-windows-xp-targeting/1383023>,<br>
> the compiled rcedit.exe doesn't run on Win XP, even when statically linking<br>
> the C runtime. It looks like I would have to install a copy of VS 2015<br>
> together with another toolchain and Windows SDK, what a nightmare.<br>
> Maybe I'll just write a 10-line FB function to compute and set the<br>
> checksum (which is far simpler than doing it using the winapi checksum<br>
> function!) I might need such a utility anyway for embedding data files in<br>
> game/custom.exe.<br>
><br>
> —<br>
> You are receiving this because you commented.<br>
> Reply to this email directly, view it on GitHub<br>
> <https://github.com/ohrrpgce/ohrrpgce/issues/38#issuecomment-913183531>,<br>
> or unsubscribe<br>
> <https://github.com/notifications/unsubscribe-auth/AA2IR6KM4T66TXI76LQ2B4LUAOJQTANCNFSM4IQ3INFA><br>
> .<br>
> Triage notifications on the go with GitHub Mobile for iOS<br>
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675><br>
> or Android<br>
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.<br>
><br>
><br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ohrrpgce/ohrrpgce/issues/38#issuecomment-913427738">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AMWGWZUFWZERO5QTIBVR2ALUARXHNANCNFSM4IQ3INFA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AMWGWZT4DYGT2H7YCY66JOTUARXHNA5CNFSM4IQ3INFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGZY42GQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ohrrpgce/ohrrpgce/issues/38#issuecomment-913427738",
"url": "https://github.com/ohrrpgce/ohrrpgce/issues/38#issuecomment-913427738",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>