<p></p>
<p>This is almost solved!</p>
<p>Firstly, rescanning the previous file, the number of detections dropped to just 7/66 (including Microsoft and McAfee). But they're detecting it based on learning from the previous false positive I think. Embedding an icon in a fresh nightly copy of game.exe produces just 2/66 detections, from only obscure scanners.</p>
<p>Looking at the rcedit issue tracker I discovered that this problem is caused by rcedit not updating the .exe checksum, so I fixed rcedit to do so, solving the problem! 0/66 detections.</p>
<p>However I compiled rcedit using Visual Studio 2019 using the "v141_xp" toolchain which supposedly targets Windows XP. Unfortunately, <a href="https://developercommunity.visualstudio.com/t/visual-studio-1692-breaks-windows-xp-targeting/1383023" rel="nofollow">it doesn't actually</a>, the compiled rcedit.exe doesn't run on Win XP, even when statically linking the C runtime. It looks like I would have to install a copy of VS 2015 together with another toolchain and Windows SDK, what a nightmare.<br>
Maybe I'll just write a 10-line FB function to compute and set the checksum (which is far simpler than doing it using the winapi checksum function!) I might need such a utility anyway for embedding data files in game/custom.exe.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ohrrpgce/ohrrpgce/issues/38#issuecomment-913183531">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AMWGWZRZXDU3L7TOPBIZXUDUAOJQVANCNFSM4IQ3INFA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AMWGWZRY7FDUL55CMK555SDUAOJQVA5CNFSM4IQ3INFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGZXBGKY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ohrrpgce/ohrrpgce/issues/38#issuecomment-913183531",
"url": "https://github.com/ohrrpgce/ohrrpgce/issues/38#issuecomment-913183531",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>