<p></p>
<p>Now, here is the question!</p>
<p>Do we fix this by saving the intended return value for addhero and then restoring it at the right moment when the on-add-hero script exists?</p>
<p>Or do we fix it by documenting that and on-add-hero script trigger's return value replaces the return value of the addhero command?</p>
<p>I am leaning towards the first, even though the implementation seems like it might be a little hacky, it seems to be the more correct thing to do, and the "feature" of returning the result of the on-add-hero script instead seems unwanted and annoying</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ohrrpgce/ohrrpgce/issues/1186#issuecomment-751488882">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AMWGWZQESUPKMPJQIG3OC23SW5PHBANCNFSM4VKJ2YQQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AMWGWZVIDO2JIHL6A4Z2F2DSW5PHBA5CNFSM4VKJ2YQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFTFM64Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ohrrpgce/ohrrpgce/issues/1186#issuecomment-751488882",
"url": "https://github.com/ohrrpgce/ohrrpgce/issues/1186#issuecomment-751488882",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>