<div dir="ltr">OK, I've done this, will check it in later.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 2 January 2018 at 18:17, James Paige <span dir="ltr"><<a href="mailto:Bob@hamsterrepublic.com" target="_blank">Bob@hamsterrepublic.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I guess I never ran into this bug because I always use the text box connection browser to add all my new instead/after conditions.<div><br></div><div>Adding a tool to check for "never" after chains and running it once on upgrade sounds like a good idea.<div><div class="h5"><br><br>On Monday, January 1, 2018, Ralph Versteegen <<a href="mailto:teeemcee@gmail.com" target="_blank">teeemcee@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 2 January 2018 at 17:19, Ralph Versteegen <span dir="ltr"><<a href="mailto:teeemcee@gmail.com" target="_blank">teeemcee@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On 2 January 2018 at 03:55, <span dir="ltr"><<a href="mailto:subversion@hamsterrepublic.com" target="_blank">subversion@hamsterrepublic.co<wbr>m</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">teeemcee<br>
2018-01-01 06:55:47 -0800 (Mon, 01 Jan 2018)<br>
953<br>
Fix two bugs involving textbox 'after' links, one quite nasty.<br>
<br>
In the textbox editor, pressing Ctrl+Left/Right to link to another box appeared<br>
to work but actually the "After" tag condition didn't get set to "Always",<br>
although it claimed it was. It didn't actually get set to "Always" until you<br>
entered a submenu. The textbox editor doesn't save when you exit (instead, its<br>
meant to save when data is edited), so it's possible that what appears to be the<br>
state of the textbox never makes it to disk.<br>
Reported by Taoki.<br>
<br>
The in-game F1 textbox debug screen also showed "ALWAYS" instead of "NEVER"<br>
(this only affected the After box/script option; tags aren't shown for other<br>
conditionals), which made this bug even more confusing.<br>
<br>
The bug was that these lines of code were in the wrong order:<br>
SaveTextBox box, <a href="http://st.id" rel="noreferrer" target="_blank">st.id</a><br>
update_textbox_editor_main_me<wbr>nu box, menu()<br>
but to make this less confusing I instead split out "textbox_set_after_textbox"<br>
---<br>
U wip/game.bas<br>
U wip/textboxedit.bas<br>
U wip/whatsnew.txt<br></blockquote><div><br></div></span><div>Note that this bug is a lot like a data corruption bug: what you see in the textbox editor isn't what actually happens in-game, so unless you actually tested your textbox chains, you wouldn't know whether they're broken. Entering any submenu fixed the problem. They're still broken, but at least now you can see it. You would have to look through all your textboxs to be certain you're not affected.<br></div><div><br></div><div>So it might be a good idea to scan the game for After chains with a Never condition and warn people about them. This only has to happen once, so could be done in upgrade() and controlled by a fixbit.</div><div>But, that's a lot of trouble, and it's unlikely to be affected by it...<br></div></div></div></div></blockquote><div>*people are unlikely to be affected <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div><br></div><div>Also, there was another bug I didn't mention: if you intentionally set an After chain with a Never condition, it would get turned into an Always condition when you exited the conditional editor (and actually saved that way).<br></div></div></div></div>
</blockquote></div><br></div></div>
</blockquote></div></div></div>
<br>______________________________<wbr>_________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org">ohrrpgce@lists.motherhamster.<wbr>org</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.<wbr>org/listinfo.cgi/ohrrpgce-<wbr>motherhamster.org</a><br>
<br></blockquote></div><br></div>