<div dir="ltr"><div>Well, I wasn't being entirely serious; it's up to you.<br></div><div>Actually, I didn't realise that FB does NOT let you write something shorter like<br></div><div><div class="gmail-m_2086274719445929894gmail-ajy"><img class="gmail-m_2086274719445929894gmail-ajz" id="gmail-m_2086274719445929894gmail-:kb" src="https://mail.google.com/mail/u/0/images/cleardot.gif" alt=""> DIM as ConstantListBrowser constb(npc_movetypes())</div><div class="gmail-m_2086274719445929894gmail-ajy">...so using a constructor isn't so great.</div><div class="gmail-m_2086274719445929894gmail-ajy">But amusingly, it turns out that you can actually write</div><div class="gmail-m_2086274719445929894gmail-ajy"> DIM constb as ArrayBrowser = npc_usetypes()</div>but this only works for constructors with a single argument.<br><div class="gmail-m_2086274719445929894gmail-ajy"></div><div class="gmail-m_2086274719445929894gmail-ajy"><br></div><div class="gmail-m_2086274719445929894gmail-ajy">However, we could instead use static member functions, like<br> npcdata.activation = ArrayBrowser.browse(npcdata.<wbr>activation, npc_usetypes())</div><div class="gmail-m_2086274719445929894gmail-ajy">in this case browse would construct an ArrayBrowser and then call the (existing) internal browse method, renamed browse_ or somesuch.<br></div><div class="gmail-m_2086274719445929894gmail-ajy">But again, this only saves one line of code!<br></div><div class="gmail-m_2086274719445929894gmail-ajy"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 16 September 2017 at 03:50, James Paige <span dir="ltr"><<a href="mailto:Bob@hamsterrepublic.com" target="_blank">Bob@hamsterrepublic.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div>dim constb as ConstantListBrowser = ConstantListBrowser(npc_movety<wbr>pes())<br><br></div>vs<br><br>dim constb as ConstantListBrowser<br></div>constb.set_list npc_movetypes()<br><div><div><br></div><div><br></div><div>Meh, I could go either way I guess.</div><div>If you really prefer the constructor method, I'll just do that. :)<br></div><div><br></div><div><br></div></div></div><div class="gmail-m_2086274719445929894HOEnZb"><div class="gmail-m_2086274719445929894h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 15, 2017 at 7:52 AM, Ralph Versteegen <span dir="ltr"><<a href="mailto:teeemcee@gmail.com" target="_blank">teeemcee@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>But that's an extra line of code! :P</div></div><div class="gmail-m_2086274719445929894m_-7013061184622314486HOEnZb"><div class="gmail-m_2086274719445929894m_-7013061184622314486h5"><div class="gmail_extra"><br><div class="gmail_quote">On 16 September 2017 at 02:35, James Paige <span dir="ltr"><<a href="mailto:Bob@hamsterrepublic.com" target="_blank">Bob@hamsterrepublic.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div>Yes, I think you are right.<br><br></div>Some single-use lists will actually have a reason to be separate classes, but the ones I have implemented so far don't have any such reason.<br><br></div>I'll probably go with a .set_array() method, rather than a constructor, since that seems a little more readable, and a little more flexible<br><br></div>I'll change those as soon as I have time.<br><div><br></div><br></div><div class="gmail-m_2086274719445929894m_-7013061184622314486m_-8523716391350318809HOEnZb"><div class="gmail-m_2086274719445929894m_-7013061184622314486m_-8523716391350318809h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 15, 2017 at 5:13 AM, Ralph Versteegen <span dir="ltr"><<a href="mailto:teeemcee@gmail.com" target="_blank">teeemcee@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I'm impressed - I didn't think flexmenu would show some flexibility! :) flexmenu does at least get the focus on data right, just not how you provide the data!</div><div><br></div><div>I'm not a fan of creating a separate class for every array of constants, even if it's only 6 lines of code each time, if that class is only going to be used in one place. Why not just have a generic class which allows passing a list of strings to its constructor (or other method)? That way it can work even if the array isn't global.<br></div><div></div><div>Likewise, I imagine that once we have a new spriteset system and animations almost all the differences between different sprite types will disappear, even backdrops. (All sprite browsers should scale down huge sprites)<br></div><div>But I notice that attacks always animate, while everything else only animates when selected. Is that intentional?<br></div><div><div class="gmail-m_2086274719445929894m_-7013061184622314486m_-8523716391350318809m_-5778793575153123917h5"><div><div><div class="gmail_extra"><br><div class="gmail_quote">On 15 September 2017 at 10:17, <span dir="ltr"><<a href="mailto:subversion@hamsterrepublic.com" target="_blank">subversion@hamsterrepublic.co<wbr>m</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">james<br>
2017-09-14 15:17:29 -0700 (Thu, 14 Sep 2017)<br>
245<br>
Add FlexmenuCaptionBrowser which is automatically used in a bunch of places in the Attack editor and Enemy editor<br>
(I think I can honestly say this is the first time in more than 10 years that doing a thing in the flexmenu code has been pleasant)<br>
---<br>
U wip/attackedit.bas<br>
U wip/thingbrowser.bas<br>
U wip/<a href="http://thingbrowser.bi" rel="noreferrer" target="_blank">thingbrowser.bi</a><br>
______________________________<wbr>_________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.o<wbr>rg</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org<wbr>/listinfo.cgi/ohrrpgce-motherh<wbr>amster.org</a><br>
</blockquote></div><br></div></div></div></div></div></div>
<br>______________________________<wbr>_________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.o<wbr>rg</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org<wbr>/listinfo.cgi/ohrrpgce-motherh<wbr>amster.org</a><br>
<br></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.o<wbr>rg</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org<wbr>/listinfo.cgi/ohrrpgce-motherh<wbr>amster.org</a><br>
<br></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.o<wbr>rg</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org<wbr>/listinfo.cgi/ohrrpgce-motherh<wbr>amster.org</a><br>
<br></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
Ohrrpgce mailing list<br>
<a href="mailto:ohrrpgce@lists.motherhamster.org" target="_blank">ohrrpgce@lists.motherhamster.o<wbr>rg</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org<wbr>/listinfo.cgi/ohrrpgce-motherh<wbr>amster.org</a><br>
<br></blockquote></div><br></div></div>