<br><br>On Saturday, July 1, 2017, Ralph Versteegen <<a href="mailto:teeemcee@gmail.com">teeemcee@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 2 July 2017 at 18:04, Ralph Versteegen <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','teeemcee@gmail.com');" target="_blank">teeemcee@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On 1 July 2017 at 17:10, James Paige <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','Bob@hamsterrepublic.com');" target="_blank">Bob@hamsterrepublic.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I was actually thinking of making it so that attempting to open the menu when pathing always queues a menu open. The option would only change whether or not the menu cancels the path.<br></div></div></blockquote><div><br></div></span><div>Ah. However, if you walk a long way across the screen, it seems pretty odd that the menu would open several seconds later. I guess it really doesn't matter.<br><br></div><div>However there's a possibility for lots of other weird effects. For example if a script suspends the player for a cutscene and then paths the hero, and the player presses esc, that esc will be queued (because the hero is pathing) but delayed until the player is resumed, possibly minutes later! And there's a long list of other things that can cause a queued menu key to be delayed. I think we should move the update_hero_pathfinding_menu_q<wbr>ueue() line inside that big IF block, with only nonzero xgo/ygo causing a menu key to be queued.<br></div></div></div></div></blockquote><div><br></div><div>I fixed that myself. But I noticed that right-clicking to open the menu doesn't work while you're in a vehicle. That's handled in update_vehicle_state, in a rather complicated way, ugh.<br><br></div><div>Unless you have some other purpose for right-clicking in mind aside from cancel/menu, or want to have fine-grained options for where it works, I think would be easil think that right-clicking should set carray(ccMenu).<br></div><div>To allow more fine-grained options, we can split up ccMenu from ccCancel... well, I guess that the main menu is the only place where ccMenu would be used.<br></div><div>Setting ccMenu on rightclick would mean replacing user_triggered_main_menu() with carray(ccMenu) > 1, and otherwise the current menu logic would remain the same.<br><br></div></div></div></div></blockquote><div>Oh, yeah. That is a good idea. I like that.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Aside: pathing the hero over the edge of a wrapping map doesn't work. Maybe a hero_collision_check bug?<br></div><div>Even without being the one working on it, I can see that is turning out to quite a bit more work than I expected!<br></div><div> </div></div></div></div></blockquote><div><br></div><div>Yep, this is a big feature all right :)</div><div><br></div><div>I'll check out the wrapping map problem. I am not sure what would make it different </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> <br></div><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Fri, Jun 30, 2017 at 10:06 PM, Ralph Versteegen <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','teeemcee@gmail.com');" target="_blank">teeemcee@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On 1 July 2017 at 05:12, <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','subversion@hamsterrepublic.com');" target="_blank">subversion@hamsterrepublic.co<wbr>m</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">james<br>
2017-06-30 10:12:33 -0700 (Fri, 30 Jun 2017)<br>
85<br>
Activating the menu (using the normal menu keys) now works properly when pathfinding<br>
---<br>
U wip/game.bas<br>
U wip/<a href="http://game.bi" rel="noreferrer" target="_blank">game.bi</a><br>
U wip/<a href="http://game_udts.bi" rel="noreferrer" target="_blank">game_udts.bi</a><br></blockquote><br></span>I didn't immediately realise that this causes the menu to be queued and shown once the hero stops moving.<br><br></div><div class="gmail_quote">I think the "Cancel move on menus" option's name is unclear, because if it's off then the menu key does nothing while pathing. Also, "menus" is very misleading because it actually refers to the keyboard menu key rather than a menu being shown.<br>Maybe "Cancel and show menu on menu key" or "Cancel move on menu key" or with a hint: "Enable menu key while moving: YES (cancels move)"<br><br></div></div></div>
<br></div></div><span>______________________________<wbr>_________________<br>
Ohrrpgce mailing list<br>
<a href="javascript:_e(%7B%7D,'cvml','ohrrpgce@lists.motherhamster.org');" target="_blank">ohrrpgce@lists.motherhamster.o<wbr>rg</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org<wbr>/listinfo.cgi/ohrrpgce-motherh<wbr>amster.org</a><br>
<br></span></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
Ohrrpgce mailing list<br>
<a href="javascript:_e(%7B%7D,'cvml','ohrrpgce@lists.motherhamster.org');" target="_blank">ohrrpgce@lists.motherhamster.o<wbr>rg</a><br>
<a href="http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org" rel="noreferrer" target="_blank">http://lists.motherhamster.org<wbr>/listinfo.cgi/ohrrpgce-motherh<wbr>amster.org</a><br>
<br></blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>
</blockquote>