[Ohrrpgce] [ohrrpgce/ohrrpgce] Skip Turn not auto-added if all attacks have no valid targets (Issue #1296)

Ralph Versteegen notifications at github.com
Sat Jan 10 03:33:13 PST 2026


rversteegen created an issue (ohrrpgce/ohrrpgce#1296)

Skip Turn is added automatically to the hero battle menu if there's nothing the player can do, but when evaluating whether a spell list or item is usable `spell_menu_is_usable` and  `items_menu_is_usable` only check costs, they don't check `has_valid_targs`.  On the other hande `does_battle_menu_have_targets` does check `has_valid_targ` for attacks in the battle menu.

To reproduce in turntest.rpg: change Punch to a Jump attack, grab a Cure potion, and go into a battle with an enemy that uses Punch. After everyone jumps you'll be stuck. Cure is set to target Ally Not Dead so isn't usable on hidden.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1296
You are receiving this because you are subscribed to this thread.

Message ID: <ohrrpgce/ohrrpgce/issues/1296 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20260110/7de4c8be/attachment-0001.htm>


More information about the Ohrrpgce mailing list