[Ohrrpgce] [ohrrpgce/ohrrpgce] Enemies with on-death bequest attacks that die to poison delay attack for a turn (#1116)

[Ralph Versteegen]

I've heard of two or three more people complaining of this bug recently. It's a problem not just because it causes stuck battles, but also it's bad for on-death effects, e.g. to transmog an enemy into a dead version.

The fundamental problem is the timing of when poison/regen happens in a turn-based battle: right at the start of the round (in `start_next_turn`), before anyone picks their attacks, rather than at the same time as the attacks. So poison damage can trigger on-death attacks (and in future other kinds of reactions too) but those reactions can't happen because it's the wrong phase of battle. Notably, stun and mute are updated after attacks are chosen.

So this does differ from #1007 in several ways.

We could move poison/regen to the end of battle once the attack queue is empty, so that from the view of the player the timing is still identical. We could then immediately perform any resulting on-death attack. That would be a turn earlier than it used to be but I doubt it would ever be a game-breaking change, more likely to be game-fixing. It will affect difficulty of some battles, but not much because the on-death bequesting enemy is currently untargettable and (I think) gets no turn.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1116#issuecomment-1263047649
You are receiving this because you are subscribed to this thread.

Message ID: <ohrrpgce/ohrrpgce/issues/1116/1263047649 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20220929/bbe0a84c/attachment.htm>