[Ohrrpgce] SVN: james/12812 Fix incorrect assumption in is_foe_of() that prevented turncoats from at

[James Paige]

If a combatant is a turncoat, but not a defector, then they should be able
to attack themselves. For a "Confusion" attack used on an enemy, when that
enemy is alone in battle, this is vital, otherwise they will frequently be
unable to act at all.

If a combatant is a defector, but not a turncoat, they should be able to
attack themselves because they are grouped with the other side for the
purposes of all targeting, including their own.

A charmed hero being unable to self-heal seems like expected behavior to
me. A charmed hero can heal enemies, which is expected.

On Tue, Mar 1, 2022 at 10:23 PM Ralph Versteegen <teeemcee at gmail.com> wrote:

> I find this a bit dubious. This change affects both combatants that are
> Defectors but aren't Turncoats and vice versa. It seems like a case of
> doing what is specified literally, rather than what is intended/wanted.
> When would you actually want someone to attack themselves? For example if a
> hero is charmed but you don't want to give the player the option to attack
> them, this results in them attacking themselves and being unable to
> self-heal.
>
> On Mon, 21 Feb 2022 at 05:13, <subversion at hamsterrepublic.com> wrote:
>
>> james
>> 2022-02-20 08:13:31 -0800 (Sun, 20 Feb 2022)
>> 166
>> Fix incorrect assumption in is_foe_of() that prevented turncoats from
>> attacking themselves
>>
>> It is perfectly normal for a turncoat to be its own foe and attack itself.
>> ---
>> U   wip/bmodsubs.bas
>>
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20220301/c0600a35/attachment-0001.html>