[Ohrrpgce] SVN: teeemcee/12520 Global NPC editor was badly broken when entered directly from NPC placem

subversion at HamsterRepublic.com subversion at HamsterRepublic.com
Wed Sep 29 19:28:50 PDT 2021


teeemcee
2021-09-29 19:28:47 -0700 (Wed, 29 Sep 2021)
717
Global NPC editor was badly broken when entered directly from NPC placement mode

There are three ways to directly edit a global NPC other than via npcdef_editor
("Edit Global NPCs").

If entered this way, any edits were discarded.  And after exiting the editor,
local NPC graphics were loaded into the global NPC npc_img() array, resizing it
to the wrong size and causing various array OOB crashes. And of course one-time-
use tag checking was broken too.

All this was heralded by the comment that read
"(npcdata should be an element of st.map.npc_def() and when it isn't we would be using the other overload)"
which indicated that the function didn't work for global NPCs, but it was wrong
about the other overload
---
U   wip/mapsubs.bas
U   wip/whatsnew.txt



More information about the Ohrrpgce mailing list