[Ohrrpgce] [ohrrpgce/ohrrpgce] Add support for Steam achievements (PR #1229)

[Mike Caron]

> Steamworks initialization

I do believe we need to initialize Steamworks before we create the window, so it can hook into opengl/etc properly. Especially if we add the `SteamAPI_RestartAppIfNecessary` call, since otherwise the window would flash on the screen and then immediately vanish.

I wonder if we could supress the console messages somehow? Maybe by closing stdout?

I agree that we should add the libraries to the distribute game feeature. I've been thinking about how to do this properly (again, especialy for the `SteamAPI_RestartAppIfNecessary` call) but we can discuss that elsewhere.

> <1/2/4 space indentation>

Agree on 1 space being bad. 4 spaces is pretty standard in all the code bases and languages that I usually work with, but I'm happy to switch it here (other than the labour of fixing it, but that's what scripting tools are for)

> <Namespace indentation>

I would like to push back a little on this. Even in C++, it is common to indent within namespaces... right?

* googles *

oh my god it isn't. hm.

Well, either way, this is not C++ and not indenting namespaces reads wrong to me. It's not as though we are trying to save characters here. Also, there do exist things outside of namespaces in these files, which imo makes it more important.

If you insist, I will unindent, but let it be known that I don't like it!

> <Steam.reward_achievement>

It should be called for all achievements; Steam will not display it multiple times. It should, however, check for the existence of a steam id before doing so!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/pull/1229#issuecomment-974887449
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20211121/0f2a48ce/attachment.html>