[Ohrrpgce] [ohrrpgce/ohrrpgce] Add support for Steam achievements (PR #1229)

[Ralph Versteegen]

I don't think I'll get through all the code, though I probably looked over all of it at some point. It does look noticeable cleaner now though!

I just realised that Game now prints to the terminal every single
```
[S_API] SteamAPI_Init(): SteamAPI_IsSteamRunning() did not locate a running instance of Steam.
[S_API] SteamAPI_Init(): Loaded '/home/ralph/.local/share/Steam/linux32/steamclient.so' OK.
[S_API FAIL] SteamAPI_Init() failed; create pipe failed.


I think you should use `boolean` as the translation of C/C++ `bool` in the translations of the API functions in `steam.bas`, especially when passing a pointer to `dim bFailed as boolint`. (My previous use of `boolint` was where I also used matching `boolint` in C, and was due to my misunderstanding of `boolean`. I should get rid of it).

I think maybe we technically should remove the comments in steam_internal.bi since they're probably copyrightable but I don't think the original C header was meant to be. But I know that C# wrapper you linked just contained

We have inconsistent indentation but I reserve the right to complain about indentation in new code regardless! Nowhere else do we indent code inside a namespace, and since it encompasses all of `achievements.rbas` I feel it's a bit pointless. Also, I get the impression you have your editor set to use 4-space tabs, but used spaces to indent rather than tabs. I think the rest of the codebase uses either tab, 1 space (which I oppose), or 2 space indentation, so 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/pull/1229#issuecomment-974074156
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20211119/f5575921/attachment-0001.html>