[Ohrrpgce] [ohrrpgce/ohrrpgce] "UPDATE_WALKABOUT_POS: missing sprite component" (#1137)

[James Paige]

Okay, I found a fix for this.

Swapping an active hero and a reserve hero means that you end up with a reserve hero's slice parented to the hero layer, and a active hero's slice parented to the reserve layer.

This normally doesn't matter, and gets fixed every tick when sorting the heroes for drawing.

But it matters if a change of map happens in the same tick as a hero swap, because in that case, the code that preserves the active heroes from deletion when recreating the hero layer misses one, because it is still parented to the reserve layer even though it belongs to an active hero now

At least I THINK that was what was happening, :D

At any rate, this does fix the crash for me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1137#issuecomment-830984472
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20210502/5e178939/attachment.html>