[Ohrrpgce] [ohrrpgce/ohrrpgce] Attack costs megabug (#1098)

[Ralph Versteegen]

Two more bugs from #1161. If you have an attack with "Check costs when used as an item" OFF attached to an item, and it has a cost (eg MP) that isn't met you can use it in the Items menu, but:
* unless "Automatically choose target" is ON the cost will be re-checked anyway, unconditionally, in the `battle_targetting` function, and the attack will be cancelled
* if "Re-check costs after attack delay" is ON, costs will be rechecked after the delay and it'll be cancelled

I long ago reached the point of despair ... is it really possible to fix a feature that's broken in far more cases than in which it works? Is the code salvageable or should we rename all the functions and variables to `buggy_atkallowed`, etc, and reimplement alternatives from scratch?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1098#issuecomment-687687447
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20200905/25345ec3/attachment.html>