[Ohrrpgce] [ohrrpgce/ohrrpgce] SDL_mixer crash on Mac when loading a MIDI (#1128)

[Ralph Versteegen]

Ravancloak twice had a crash while playing [I AM BEAN BOY](https://www.slimesalad.com/forum/viewgame.php?p=137050), and also other audio glitches.

> rue9x: she also said that when the "beep" sound plays (there's a on-step script that plays a footfall beep sound) all of the audio cut out
> rue9x: but that might have been coincidental

Here is the OSX-generated crash log: [bean_boy_crash.txt](https://github.com/ohrrpgce/ohrrpgce/files/4640252/bean_boy_crash.txt)

Mac OS X 10.13.6
O.H.R.RPG.C.E version gorgonzola 20200502 (x86_64)
SDL 1.2.14
SDL_mixer 1.2.11

The log shows that the crash happens inside SDL_mixer when the mixing thread dereferences `music_playing->type` (this code-path occurs only on Mac) while the main thread is in the process of loading a MIDI (inside `native_midi_start` in a `Mix_FadeInMusicPos` call). So this is apparently clearly a race condition in SDL_mixer, and their bug.

SDL_mixer 1.2.11 is out of date, 1.2.12 has "Fixed looping native MIDI on Mac OS X and Windows" in the changelog. I'd like to verify that 1.2.12 actually fixes this, though. It looks like there will be one more SDL_mixer 1.2 bugfix release soon.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1128
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20200517/18809685/attachment.html>