[Ohrrpgce] [ohrrpgce/ohrrpgce] Incorrect starting scroll position in sprite editor browser (#1110)

[Ralph Versteegen]

There are multiple scrolling glitches, which I think affect plankmenus in general. But the spriteset browser/editor has a lot of its own code for scrolling. I had a lot of trouble getting the level of glitchness as low as it is. A particular problem is that CoverChildren and Layout slices conflict with each other so it's hard to calculate the correct slice positions (see bottom of `SpriteSetBrowser.rebuild_menu`). Incidentally this is the reason that both of those aren't exposed to users yet.

I found a lead: the scroll position when entering the menu isn't determined solely by the vertical position of the selected spriteset/frame, although all planks (frames) within one spriteset cause the same scroll offset.  If you have multiple spritesets on the same row to each other, as you go further to the right the scroll position starts off further down, until the selection is off the top of the screen.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1110#issuecomment-606321852
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20200330/944d8e23/attachment.html>