[Ohrrpgce] [ohrrpgce/ohrrpgce] "add hero" command return value doesn't work (#1186)

[Ralph Versteegen]

Ah ha! Setting a watchpoint on scriptret in gdb revealed that the on-add-hero hook script is triggered when `add hero` is called, clobbering the return value. Welcome to the new world of script interpreter reentrancy bugs! By which I don't mean we recursively call `scriptinterpreter` but it does switch script while executing a command. This already happens when calling `run script by id` but in that case the return value from the script is the return value from the command.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1186#issuecomment-751452017
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20201227/e233c05d/attachment.html>