[Ohrrpgce] [ohrrpgce/ohrrpgce] Memory corruption crash on Mac (#1140)

[Ralph Versteegen]

Note that the crash report shows obsolete SDL 1.2.14 and SDL_mixer 1.2.11 in use, which is what was installed on the nightly build machine at that time.

Although the memory corruption could be happening anywhere, the crash is inside SDL_Flip->SDL_SoftStretch, specifically in CoreGraphic's color space conversion.

In the SDL 1.2.15 changelog:
> - Fixed memory stomp when using stretch blit on large images.

(Maybe this refers to blitting between SDL_Surfaces rather than to SDL_Flip)

In the changelog for SDL 1.2.16 (unreleased in compiled form, and never will be)

> - Mac OS X: fix crash on any input in Quartz code (bug 2560.)
> - Mac OS X: fix crash in Quartz gamma ramp code.

SDL and SDL_mixer have a large number of unreleased fixes in hg. Although we're switching to SDL2, assuming some users will still use gfx_sdl/music_sdl we should upgrade all our Windows and Mac SDL/SDL_mixer builds to latest hg versions. Even though I compiled SDL_mixer.dll myself, I did so using the 8-year-old 1.2.12 release.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1140#issuecomment-682289689
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20200827/4ee76f16/attachment.html>