[Ohrrpgce] [ohrrpgce/ohrrpgce] "UPDATE_WALKABOUT_POS: missing sprite component" (#1137)

[Ralph Versteegen]

Marking this a release-blocker because people are running into it a lot. This was probably introduced by the hero slice lifespan changes in gorgonzola.

RMZ encountered it when swapping out and locking a hero right before changing maps without a wait. Adding a wait worked around it.

Wobbler ran into it in KBB and emailed us a testcase. It crashed at the end of the Dr. Cube RPG. Again, his script did `add hero` and `swap out hero` immediately before a `use door`, and moving them after the `use door` fixed it.

We have a mountain crash reports for this, which come in a quite a variety, including:

```
__________________________________________________________________________________________
8c92ce  20200720  wip 20200530.11864             ...debugc <- SET_WALKABOUT_SPRITE(walkabouts.bas:139) <- VISHERO <- PARTY_CHANGE_UPDATES <- DOLOADGAME
Game    col***    Win/32/gfx_directx             SET_WALKABOUT_SPRITE: missing sprite component
                  viking.rpg Vikings of Midgard 
__________________________________________________________________________________________
394866  20200801  wip 20200731.11936             ...debugc <- SET_WALKABOUT_SPRITE(walkabouts.bas:139) <- VISHERO <- PARTY_CHANGE_UPDATES <- ADDHERO <- ADD_REM_SWAP_LOCK_HERO
Game    pau***    Win/32/gfx_directx             SET_WALKABOUT_SPRITE: missing sprite component
                  kaiju.rpg Kaiju Big Battel Fi 
__________________________________________________________________________________________
d73846  20200801  wip 20200731.11936             ...debugc <- UPDATE_WALKABOUT_POS(walkabouts.bas:176) <- UPDATE_WALKABOUT_NPC_SLICES <- DISPLAYALL <- main
Game    pau***    Win/32/gfx_directx             UPDATE_WALKABOUT_POS: missing sprite component
                  kaiju.rpg Kaiju Big Battel Fi  
__________________________________________________________________________________________
628ae2  20200801  wip 20200731.11936             OrphanSlice(slices.bas:632) <- SetSliceParent <- UPDATE_WALKABOUT_HERO_SLICES <- UPDATE_WALKABOUT_SLICES
Game    pau***    Win/32/gfx_directx             EXCEPTION_ACCESS_VIOLATION_READ
                  kaiju.rpg Kaiju Big Battel Fi  
__________________________________________________________________________________________
f6243a  20200823  wip 20200823.11965             ChangeSpriteSlice(slices.bas:2247) <- SET_WALKABOUT_SPRITE <- VISHERO <- SCRIPT_FUNCTIONS <- SCRIPTINTERPRETER_LOOP
Game    col***    Win/32/gfx_directx             EXCEPTION_ACCESS_VIOLATION_WRITE
                  AxeCop.rpg Axe Cop             
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1137#issuecomment-679075435
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20200824/3386caad/attachment-0001.html>