[Ohrrpgce] [ohrrpgce/ohrrpgce] Delaying by X attacks delays by X turns instead when there's also a turn delay (#1118)

[Ralph Versteegen]

The "Delay/Advance attack by X attacks" setting (turn-based battles only) is meant to change the order in which attacks happen during a single turn, but it seems to cause a delay by that many turns instead if combined with a turn delay

> Feenick: another attack delay-related bug: it seems that attacks delayed by attacks can go off into another turn [as opposed to being guaranteed to be at the end of the turn, as I was intending to use the function]
> tmc: is the "Delay doesn't block further actions" bit on? is the attack part of a chain?
> Feenick: Yeah, both of those are the case
> tmc: is it the start of the chain? end? does the rest of the chain have any delays? I think I'd have to see the .rpg
> Feenick: It's a one-turn delay with an additional 1-attack delay. It's the second in a chain

Here's a testcase Feenick sent me; the hero's attack chains to an attack with a delay of 1 turn and 4 attacks: [delaytest.zip](https://github.com/ohrrpgce/ohrrpgce/files/4529807/delaytest.zip)
You can see the attacks build up in the queue.

Incidentally this "Delay/advance attack" setting is so confusingly named that I was initially very confused, and then really struggled to refer to it while writing this bug.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/1118
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20200424/8d64816c/attachment-0001.html>