[Ohrrpgce] SVN: teeemcee/10923 Fix crash when clicking on a one-time-usable NPC

Ralph Versteegen teeemcee at gmail.com
Fri Jan 18 19:21:45 PST 2019


On Sat, 19 Jan 2019 at 16:21, Ralph Versteegen <teeemcee at gmail.com> wrote:
>
> Hah, oops! Guess I shouldn't be sniping your bugs!
>
> There were a lot of possible ways to fix this, none look much better
> than the others to me. I dithered about it a lot, actually. I think
> that when state is "overdetermined" the number of possible ways to
> write a piece of code, and its brittleness, increases hugely (e.g. in
> this case, if gam.hero_pathing(rank).by_user is true, then
> .stop_when_npc_reached is also true - should one make use of that to
> make the code simpler, or those that?)
*or does that make things worse?

>
> On Sat, 19 Jan 2019 at 15:38, James Paige <Bob at hamsterrepublic.com> wrote:
> >
> > You beat me by seconds at checking in a fix for this :)
> >
> > My fix did: IF .id > 0 ANDALSO npcs(.id - 1).activation <> 2 THEN which worked fine but was probably a bit less correct than that you did :)
> >
> > On Fri, Jan 18, 2019 at 9:07 PM <subversion at hamsterrepublic.com> wrote:
> >>
> >> teeemcee
> >> 2019-01-18 18:07:48 -0800 (Fri, 18 Jan 2019)
> >> 48
> >> Fix crash when clicking on a one-time-usable NPC
> >> ---
> >> U   wip/game.bas
> >> _______________________________________________
> >> Ohrrpgce mailing list
> >> ohrrpgce at lists.motherhamster.org
> >> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
> >
> > _______________________________________________
> > Ohrrpgce mailing list
> > ohrrpgce at lists.motherhamster.org
> > http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org


More information about the Ohrrpgce mailing list