[Ohrrpgce] [ohrrpgce/ohrrpgce] Uninitialised attack or enemy record getting appended (#17)

[Ralph Versteegen]

So the root cause of this bug was the `+ 1` in the line
``recindex = gen(genMaxEnemy) + 1``
in `enemy_editor`; ditto for attacks.
And apparently that bug was actually there since r8949 (July 2017, Dwimmercraft), which added the ability to jump between different editors. However, I think it could only be triggered by pressing Insert or + in another editor to add a new enemy/attack. When in Fufluns nightlies the Attack and Enemy thingbrowsers were added, which featured the +New button, also triggering this bug and making it easier to encounter.

For the purposes of sifting through old debug log error messages, note that this caused a "loadrecord: record # is off the end of" message when you added an enemy/attack, and a "rpgfix:Adjusting record count for Enemies/Attacks lump" message when you launched Custom next time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/issues/17#issuecomment-518963879
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20190806/6a2484e5/attachment.html>