[Ohrrpgce] SVN: teeemcee/10847 Fix serious hero data deletion bug in nightlies since r10523 (2018-09-29

[subversion at HamsterRepublic.com]

teeemcee
2018-11-05 06:27:31 -0800 (Mon, 05 Nov 2018)
1301
Fix serious hero data deletion bug in nightlies since r10523 (2018-09-29)

The cause was that NodeByPath with create=YES arg and an index, like "/hero[2]",
actually returned the first existing node named "hero" instead of creating a new
one as required. The first hero node is normally hero 0. That node would then
get overwritten in saveherodata.

The bug deleted some hero data if you either created a new hero (either as a
copy or blank), or were editing a game created a game created before
pre-Beelzebufo which still contained heroes that had never been edited
since. Once the problem started it would repeatedly keep deleting the data as
you used the hero editor.

The heroes that were affected were the newly created (or never-edited)
heroes, and hero 0. (Possibly some other hero instead of 0, but that's
unlikely.)  Affected heroes would get all of the following deleted, over and
over: the battle menu, stat visibility, counterattacks, hero level checks
(in hero tags menu), and the experience curve setting. These were all
replaced with defaults. Due to a separate bug (see previous commit),
the XP curve would get reset to 0.00 instead of the correct default, 0.20.

Also, ohrrpgce.new actually contains two heroes in its heroes.reld, so
the bug didn't happen if you created a second hero.
---
U   wip/IMPORTANT-nightly.txt
U   wip/reload.bas
U   wip/reloadext.bas
U   wip/reloadtest.bas