[Ohrrpgce] SVN: james/10244 Mouse support in the Items menu.

Ralph Versteegen teeemcee at gmail.com
Thu Mar 29 23:22:57 PDT 2018


On 30 March 2018 at 19:21, Ralph Versteegen <teeemcee at gmail.com> wrote:

>
>
> On 30 March 2018 at 16:22, James Paige <Bob at hamsterrepublic.com> wrote:
>
>>
>>
>> On Thursday, March 29, 2018, Ralph Versteegen <teeemcee at gmail.com> wrote:
>>
>>>
>>>
>>> On 30 March 2018 at 04:01, James Paige <Bob at hamsterrepublic.com> wrote:
>>>
>>>>
>>>>
>>>> On Wed, Mar 28, 2018 at 6:59 PM, Ralph Versteegen <teeemcee at gmail.com>
>>>> wrote:
>>>>
>>>>> All this additional mouse support is very nice!
>>>>>
>>>>> But in the Items menu it seems very unnatural that you have to click
>>>>> twice to select Done/Drop/Autosort or to swap an item to a new location.
>>>>> Double clicking is only necessary to select an item (use or start
>>>>> swapping); the extra click shouldn't be necessary for disambiguation in
>>>>> other cases.
>>>>>
>>>>>
>>>> Excellent point. I can fix those things. :)
>>>>
>>>>
>>>>> Also, after you double click on an item to select it, right clicking
>>>>> should probably deselect it, just as Esc does.
>>>>>
>>>>
>>>> That is also a great idea.
>>>>
>>>>
>>>>> Actually, unlike the other menus, right click doesn't exit the Items
>>>>> menu.
>>>>> I was initially concerned about right clicking anywhere closing menus,
>>>>> unlike how menus behave in Custom, but I guess it's not that important to
>>>>> be able to select menu items by right clicking. I see from your work on
>>>>> Items that menus which require selecting - Items, Shops, Equip - can easily
>>>>> be made to work with left click only (which is necessary on touch devices
>>>>> anyway)
>>>>>
>>>>>
>>>> Yes, I really like right-click to close on non-scrolling menus, and
>>>> non-modal menus that don't take up the whole screen, but on something that
>>>> scrolls like save slots or items, I think right drag to scroll is
>>>> important, especially for touch, since that will be a two-finger-drag to
>>>> scroll.
>>>>
>>>
>>> Would it be a bad idea to have both right-click to close and right-drag
>>> to scroll in the same menu? (It does sound dubious...) I can imagine it
>>> working worse with touch than mouse controls.
>>>
>>>
>>
>> I think on a non-fullscreen menu it would make sense. The right click
>> close would just work outside the scroll area.
>>
>>
>>
>>>
>>>>
>>>>> Oh, picksave/load is another menu where right click doesn't close.
>>>>> (Also, I was interested to see the scrolling by right-dragging in
>>>>> action, but it seems to be pretty broken)
>>>>>
>>>>
>>>> Yeah, I don't have it quite right yet, and I might not be able to get
>>>> it right until I sliceify the save slot picker.
>>>>
>>>
>>> Yes, I guess you really need pixel-granularity of scrolling.
>>>
>>>
>> Yes, that will help a lot. Also important is storing a dragging flag when
>> readmouse.drag_dist exceeds the threshold for the first time
>>
>
> Actually, I don't see the point of the ps.drag_scrolling flag. drag_dist
> only increases, never decreasing until the drag ends and it gets reset to
> zero.
>

Also, isn't ps.drag_scroll_start redundant to readmouse.clickstart?


>
>> , making sure right-mouse click doesn't change focus when a dragging is
>> happening, and disabling left-click selection when a dragging is happening
>>
>
>
>
>>
>>
>>>
>>>> I plan to add the same right-drag scrolling to the items menu, and
>>>> hopefully that will work better, since it is already slices.
>>>>
>>>>
>>>>
>>>>>
>>>>>
>>>>>
>>>>> On 29 March 2018 at 11:54, <subversion at hamsterrepublic.com> wrote:
>>>>>
>>>>>> james
>>>>>> 2018-03-28 15:54:34 -0700 (Wed, 28 Mar 2018)
>>>>>> 104
>>>>>> Mouse support in the Items menu.
>>>>>>
>>>>>> This was tricky with swap support, but I think it works pretty nicely.
>>>>>> ---
>>>>>> U   wip/menustuf.rbas
>>>>>> _______________________________________________
>>>>>> Ohrrpgce mailing list
>>>>>> ohrrpgce at lists.motherhamster.org
>>>>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherh
>>>>>> amster.org
>>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Ohrrpgce mailing list
>>>>> ohrrpgce at lists.motherhamster.org
>>>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> Ohrrpgce mailing list
>>>> ohrrpgce at lists.motherhamster.org
>>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>>
>>>>
>>>
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20180330/a0c82e19/attachment-0001.html>


More information about the Ohrrpgce mailing list