[Ohrrpgce] SVN: james/10215 "wait for all" now also waits for pathfinding

[Ralph Versteegen]

"npc is walking" is the same, it also returns true only for scripted
pathfinding, but not Chase (Pathfinding).
And for that matter, "npc is walking", "hero is walking", "wait for hero"
and "wait for npc" all implicitly take pathfinding to be a kind of walking
(their documentation doesn't mention pathfinding at all) but "wait for all"
implies that pathfinding doesn't count as walking.

On 27 March 2018 at 13:28, James Paige <Bob at hamsterrepublic.com> wrote:

> I can update the docs for "wait for all" to expound on its quirks.
>
>
> On Monday, March 26, 2018, Ralph Versteegen <teeemcee at gmail.com> wrote:
>
>> Not counting pathfinding as "walking" may be confusing? it's not
>> explained.
>> Looking at the code, I see that this doesn't actually wait for NPCs
>> moving according to the "Chase you (pathfinding)" movetype, which I would
>> consider pathfinding.
>> It's correct that it shouldn't wait for that, since it would never
>> finish, but it should be documented that it never waits for it, even if
>> "suspend npcs" is active. The actual behaviour of this command and the
>> backcompat break is fine, but as it's documented it doesn't make sense.
>>
>>
>>
>> On 27 March 2018 at 12:00, James Paige <Bob at hamsterrepublic.com> wrote:
>>
>>> This change does have consequences for scripts that used "pathfind npc
>>> to" together with "wait for all" but since that consequence is that those
>>> scripts are now no longer broken, I am not sure if this is a serious
>>> backcompat concern.
>>>
>>> On Mon, Mar 26, 2018 at 3:57 PM, <subversion at hamsterrepublic.com> wrote:
>>>
>>>> james
>>>> 2018-03-26 15:57:38 -0700 (Mon, 26 Mar 2018)
>>>> 45
>>>> "wait for all" now also waits for pathfinding
>>>> ---
>>>> U   wip/docs/plotdict.xml
>>>> U   wip/docs/plotdictionary.html
>>>> U   wip/scriptcommands.bas
>>>> U   wip/testgame/autotest.hss
>>>> U   wip/testgame/autotest.rpg
>>>> _______________________________________________
>>>> Ohrrpgce mailing list
>>>> ohrrpgce at lists.motherhamster.org
>>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>>
>>>
>>>
>>> _______________________________________________
>>> Ohrrpgce mailing list
>>> ohrrpgce at lists.motherhamster.org
>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>
>>>
>>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20180327/a32177de/attachment.html>