[Ohrrpgce] SVN: james/9429 Neither .bequest_attack nor .non_elem_counter_attack was being saved wit

[Ralph Versteegen]

Oh no!

I thought I'd screwed up badly when making that change. I see the problem
was that saveenemydata was broken to begin with.

Well, if we're going to release dwimmercrafty+1, there are a few patches
that could be backported... oh, too late.
It feels like too much effort to backport fixes to a release branch as we
make them if we don't know whether there will be a bugfix release.

It would be good to have testcases which read all the data out of an enemy,
hero, etc, to check that everything is in order. Then by running the latest
nightly against old copies of autotest.rpg we can check that the data is
updated correctly. But it's harder to check that all the upgrade routines
we already have, for games older than 2017, work correctly. What we could
do is craft an .rpg with an old version of custom, but import a modern .hs
into it.
But we couldn't even have written testcases for this, because there are no
script commands to access that data. "read enemy data" is intentionally
limited to index 106 only. And writing individual script commands for all
those settings is way too much work.
What we need are objects in HS so that we can access data with very minimal
code required, and minimal documentation in plotdict.



On 23 September 2017 at 09:29, James Paige <Bob at hamsterrepublic.com> wrote:

> I'll be releasing dwimmercrafty+1 with this fix. If I have time I'll do it
> today, otherwise it may have to wait for monday or tuesday
>
> On Fri, Sep 22, 2017 at 2:28 PM, <subversion at hamsterrepublic.com> wrote:
>
>> james
>> 2017-09-22 14:28:14 -0700 (Fri, 22 Sep 2017)
>> 311
>> Neither .bequest_attack nor .non_elem_counter_attack was being saved with
>> the EnemyDef version of saveenemydata
>> Ever since revision 9197, loadenemydata/saveenemy data is called on ever
>> enemy record on every full upgrade
>> so those two features were being deleted from all enemies when the rpg
>> was opened in custom
>> ---
>> U   wip/loading.rbas
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
>
>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20170923/c89f6c31/attachment-0001.html>