[Ohrrpgce] SVN: james/9425 The Editor Slice Editor now has access to all special lookup codes. The

[Ralph Versteegen]

The THINGBROWSER codes are still exposed, though (ie. they should be
renamed)

I guess I could make scons automatically run sl_lookup.py to avoid that
extra step. Updating init_slice_editor_for_collection_group is the other
extra step.

On 21 September 2017 at 06:22, James Paige <Bob at hamsterrepublic.com> wrote:

> I made sure that SL_EDITOR_* is not included in plotscr.hsd or plotdict.xml
>
> Hardcoding the special codes with kindlimits isn't actually all that
> important, now that the slice editor can run in privileged mode, and can
> access all the lookup codes.
>
> I do think it is okay to keep the hardcoded special codes and kindlimits
> as they are. They are convenient, and will probably become even more so as
> the total number of special codes grows, but now they aren't required.
>
>
> On Wed, Sep 20, 2017 at 11:16 AM, Ralph Versteegen <teeemcee at gmail.com>
> wrote:
>
>> Is there any advantage to hardcoding these lookup codes, and their
>> kindlimits, into the sliceeditor? I don't imagine we'll be editing existing
>> editor slice collections that often.
>> My idea had been to have a separate slicelookups.txt file in the data/
>> folder to be used for editor slice lookup codes, which would be negative.
>> (Replacing the normal slicelookups.txt, it would effectively hide the
>> game's lookup codes) But I'm not sure how easy that is to actually
>> implement.
>> It is useful to have constants like SL_EDITOR_SPLASH_MENU so that they
>> can be used in code. But they shouldn't be grouped with the other special
>> lookup codes, since they shouldn't appear in plotscr.hsd or the plotdict
>>
>> On 21 September 2017 at 05:46, <subversion at hamsterrepublic.com> wrote:
>>
>>> james
>>> 2017-09-20 10:46:16 -0700 (Wed, 20 Sep 2017)
>>> 284
>>> The Editor Slice Editor now has access to all special lookup codes. The
>>> are grouped right below any special codes that are preferred for the
>>> current filename, and above any user defined lookup codes (which are more
>>> or less meaningless in editor-specific slices... should I hide them?)
>>> ---
>>> U   wip/misc/sl_lookup.py
>>> U   wip/sliceedit.bas
>>> _______________________________________________
>>> Ohrrpgce mailing list
>>> ohrrpgce at lists.motherhamster.org
>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>>
>>
>>
>> _______________________________________________
>> Ohrrpgce mailing list
>> ohrrpgce at lists.motherhamster.org
>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>>
>>
>
> _______________________________________________
> Ohrrpgce mailing list
> ohrrpgce at lists.motherhamster.org
> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.motherhamster.org/pipermail/ohrrpgce-motherhamster.org/attachments/20170921/d89116b4/attachment.html>